Run filter-into-join rule early for subqueries and disable project-filter rule #15511
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Area - Batch Ingestion
Area - Querying
Area - MSQ
gianm
reviewed
Dec 7, 2023
sql/src/main/java/org/apache/druid/sql/calcite/planner/CalciteRulesManager.java
Show resolved
Hide resolved
| @@ -224,11 +224,16 @@ public CalciteRulesManager(final Set<ExtensionCalciteRuleProvider> extensionCalc | |||
| public List<Program> programs(final PlannerContext plannerContext) | |||
| { | |||
| // Program that pre-processes the tree before letting the full-on VolcanoPlanner loose. | |||
| List<RelOptRule> hepRules = new ArrayList<RelOptRule>(REDUCTION_RULES); | |||
| if (plannerContext.getJoinAlgorithm().requiresSubquery()) { | |||
| hepRules.add(CoreRules.FILTER_INTO_JOIN); | |||
There was a problem hiding this comment.
Could you please explain the reasoning about why we want this for sortMerge, but not for broadcast join? (that's essentially what requiresSubquery is checking)
There was a problem hiding this comment.
this is a very usefull rule; and would be good to run it early for every plan - however it could even by itself could create ScanQuery beneath Join-s like these which is good; however based on the discussions in #9843 and #9773
...it might not be the best for Druid;
so I've decided to only enable it when also the FANCY_JOIN rules are added - as those will pill in this rule anyway.
...ore/multi-stage-query/src/test/java/org/apache/druid/msq/test/CalciteSelectQueryMSQTest.java
Outdated
Show resolved
Hide resolved
| @@ -84,14 +85,15 @@ public class CalciteRulesManager | |||
| * those functions). | |||
| * 3) {@link CoreRules#JOIN_COMMUTE}, {@link JoinPushThroughJoinRule#RIGHT}, {@link JoinPushThroughJoinRule#LEFT}, | |||
| * and {@link CoreRules#FILTER_INTO_JOIN}, which are part of {@link #FANCY_JOIN_RULES}. | |||
| * 4) {@link CoreRules#PROJECT_FILTER_TRANSPOSE} because PartialDruidQuery would like to have the Project on top of the Filter - | |||
| * this rule could create a lot of non-usefull plans. | |||
There was a problem hiding this comment.
Suggested change
| * this rule could create a lot of non-usefull plans. | |
| * this rule could create a lot of non-useful plans that unnecessarily increase the planning time. |
abhishekagarwal87
approved these changes
Jan 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Description
Fixed the bug ...
Renamed the class ...
Added a forbidden-apis entry ...
Release note
Key changed/added classes in this PR
MyFooOurBarTheirBazThis PR has: