Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update labeler configuration for v5 #15564

Merged
merged 1 commit into from
Dec 14, 2023

Conversation

abhishekrb19
Copy link
Contributor

After #15558, @LakshSingla noticed this error in one of his jobs - https://github.com/apache/druid/actions/runs/7212566265/job/19650514677?pr=15559.

The configuration file (path: .github/labeler.yml) was not found locally, fetching via the api
Error: Error: found unexpected type for label 'Area - Batch Ingestion' (should be array of config options)
Error: found unexpected type for label 'Area - Batch Ingestion' (should be array of config options)

The issue seems related to: actions/labeler#712. This PR updates the labeler configuration format to be compatible with v5.

As with GitHub actions, we'd have to test this by merging the PR and then a follow-up PR should succeed as the workflow is run from the base branch, master in this case. If it doesn't succeed, we can perhaps revert the version back to v4.

This PR has:

  • been self-reviewed.

@abhishekrb19
Copy link
Contributor Author

Thanks @LakshSingla for the quick review! Merging it now and will follow up if there are other issues once master branch has the correct configuration in place.

@abhishekrb19 abhishekrb19 merged commit 9deeb28 into apache:master Dec 14, 2023
13 of 14 checks passed
@abhishekrb19 abhishekrb19 deleted the update_labeler_config_v5 branch December 15, 2023 05:31
@LakshSingla LakshSingla added this to the 29.0.0 milestone Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants