-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API to fetch conflicting task locks #16799
Add API to fetch conflicting task locks #16799
Conversation
indexing-service/src/main/java/org/apache/druid/indexing/common/TaskLock.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/metadata/TaskLockInfo.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/metadata/TaskLockInfo.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/server/http/TaskLockResponse.java
Outdated
Show resolved
Hide resolved
server/src/main/java/org/apache/druid/rpc/indexing/OverlordClient.java
Outdated
Show resolved
Hide resolved
indexing-service/src/main/java/org/apache/druid/indexing/overlord/TaskQueryTool.java
Outdated
Show resolved
Hide resolved
indexing-service/src/main/java/org/apache/druid/indexing/overlord/http/OverlordResource.java
Outdated
Show resolved
Hide resolved
indexing-service/src/main/java/org/apache/druid/indexing/overlord/http/OverlordResource.java
Show resolved
Hide resolved
indexing-service/src/test/java/org/apache/druid/indexing/overlord/TaskLockboxTest.java
Fixed
Show fixed
Hide fixed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @AmatyaAvadhanula !
+1 after CI passes.
@Produces(MediaType.APPLICATION_JSON) | ||
@ResourceFilters(StateResourceFilter.class) | ||
public Response getDatasourceLockedIntervalsV2(List<LockFilterPolicy> lockFilterPolicies) | ||
public Response getActiveLocks(List<LockFilterPolicy> lockFilterPolicies) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super Nit: If you reverse the order of these two methods in this class file, the diff might become smaller/simpler. 🙂
(consider doing this only if you are also fixing some other build issue in this PR)
* Add API to fetch conflicting active locks
Description
Add a new API to view the active task locks for a given set of (datasource, priority, interval list).
This can be useful to:
Changes
/lockedIntervals
/activeLocks
This PR has: