hard-code compaction tasks to use ARRAY for multi-value handling to preserve order #17110
+99
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abhishekagarwal87
approved these changes
Sep 19, 2024
gianm
approved these changes
Sep 19, 2024
| @@ -989,9 +990,13 @@ private void processDimensionsSpec(final QueryableIndex index) | |||
| // column for it. | |||
| final ColumnHolder columnHolder = index.getColumnHolder(dimension); | |||
| if (columnHolder != null) { | |||
| DimensionSchema schema = columnHolder.getColumnFormat().getColumnSchema(dimension); | |||
| if (schema instanceof StringDimensionSchema) { | |||
There was a problem hiding this comment.
A comment about why this is happening would be useful. It probably won't be obvious to a reader.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes compaction tasks to always use
MultiValueHandling.ARRAYif the column schema is not explicitly specified. This should be safe because it will just preserve whatever order the values in the row were stored in on the initial ingestion, and not re-order the values if initially ingested as unordered.