MSQ WF: Pass a flag from broker to determine operator chain transformation #17443
+74
−44
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In #17433, we had to move the operator-chain-transformation logic to the MSQ worker layer to ensure backward compatibility. But it wasn't ideal since such logic shouldn't be a responsibility of the worker.
On further offline discussion, an alternative was suggested that we can pass a flag from the broker during query execution.
If MSQ controller sees the flag, then it does the operator transformation. Otherwise it doesn't do the operator transformation.
This relies on the upgrade order of the different services. This allows us to achieve backward compatibility since brokers are upgraded after indexers/middlemanagers, so passing a flag is essentially passing info whether all indexers/middlemanagers have been upgraded or not - hence helps us achieve backward compatibility.
This PR has: