adding lower and upper extraction fn #2076
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,57 @@ | |||
| package io.druid.query.extraction; | |||
|
@b-slim upper and lowercase are locale sensitive, can we add an optional locale parameters? You can look at https://github.com/druid-io/druid/blob/master/processing/src/main/java/io/druid/query/extraction/TimeFormatExtractionFn.java#L45 for an example where we allow for locale. |
|
@b-slim let's finish this one up |
b-slim
force-pushed
the
issue_2010_upper_lower_extractionFN
branch
4 times, most recently
from
828e378
to
9c879e2
Compare
|
@gianm does this fix your issue ? |
| @@ -35,4 +35,6 @@ | |||
| public static final byte CACHE_TYPE_ID_SUBSTRING = 0x8; | |||
| public static final byte CACHE_TYPE_ID_CASCADE = 0x9; | |||
| public static final byte CACHE_TYPE_ID_STRING_FORMAT = 0xA; | |||
| public static final byte UPPER_EXTRACTION_FN_CACHE_ID = 0xB; | |||
There was a problem hiding this comment.
let's make the naming consistent
|
👍 I have a minor comment |
|
👍 after #2076 (comment) is resolved |
b-slim
force-pushed
the
issue_2010_upper_lower_extractionFN
branch
from
9c879e2
to
78feb3a
Compare
|
@fjy and @himanshug thanks ! will merge it once Travis is happy ! |
b-slim
added a commit
that referenced
this pull request
Jan 21, 2016
adding lower and upper extraction fn
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix for issue #2010