All Filters should work with FilteredAggregators. #2711
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes Filter.makeMatcher(ColumnSelectorFactory), and adds a
ValueMatcherFactory implementation to FilteredAggregatorFactory so it can
take advantage of existing makeMatcher(ValueMatcherFactory) implementations.
This also removes the Bound-based method from ValueMatcherFactory. Its only
user was the SpatialFilter, which could use the Predicate-based method.
Fixes #2604.
Has some overlap with #2690 but takes a different approach -- switching to
makeMatcher(ValueMatcherFactory) rather than implementing the missing
makeMatcher(ColumnSelectorFactory) methods.