Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompactionTask: Reject empty intervals on construction. #6059

Merged
merged 2 commits into from
Jul 30, 2018
Merged

CompactionTask: Reject empty intervals on construction. #6059

merged 2 commits into from
Jul 30, 2018

Conversation

gianm
Copy link
Contributor

@gianm gianm commented Jul 27, 2018

They don't make sense anyway, and it's better to fail fast.

@gianm
CompactionTask: Reject empty intervals on construction.
f3d661f 
They don't make sense anyway, and it's better to fail fast.
jihoonson
jihoonson reviewed Jul 27, 2018
View reviewed changes
Copy link
Contributor

@jihoonson jihoonson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 after Travis.

@jihoonson
Copy link
Contributor

Please check the Travis failure.

[ERROR] Forbidden method invocation: org.joda.time.Interval#<init>(java.lang.Object) [Uses default time zone, use factory methods from DateTimes and Intervals classes instead]
[ERROR]   in io.druid.indexing.common.task.CompactionTaskTest (CompactionTaskTest.java:462)
[ERROR] Scanned 243 (and 776 related) class file(s) for forbidden API invocations (in 1.84s), 1 error(s).

@gianm
Copy link
Contributor Author

gianm commented Jul 27, 2018

I switched to Intervals.of.

@gianm gianm merged commit 63be028 into apache:master Jul 30, 2018
@gianm gianm deleted the compact-reject-empty-interval branch July 30, 2018 15:52
@dclim dclim added this to the 0.13.0 milestone Oct 8, 2018
@soltan soltan mentioned this pull request Dec 27, 2023
Open
@terrorizer1980 terrorizer1980 mentioned this pull request Dec 27, 2023
Closed
@ajesse11x ajesse11x mentioned this pull request Dec 28, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jihoonson jihoonson jihoonson left review comments

Assignees
No one assigned
Labels
Area - Batch Ingestion
Projects
None yet
Milestone
0.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@gianm @jihoonson @dclim