New doc fixes #6156
Merged
New doc fixes #6156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
gianm
approved these changes
Aug 11, 2018
asdf2014
reviewed
Aug 12, 2018
| @@ -31,7 +31,7 @@ There will be 24 segments for this datasource, one segment per hour in the input | |||
|
|
|||
| Running a COUNT(*) query on this datasource shows that there are 39,244 rows: | |||
|
|
|||
| ``` | |||
| ```bash | |||
There was a problem hiding this comment.
Maybe using sql here would be better.
There was a problem hiding this comment.
hm, it's not purely SQL, and it shows the output from a shell, so I'll keep this as bash for now
There was a problem hiding this comment.
Okay, this also makes sense. 😅
There was a problem hiding this comment.
yeah, I think there's some ambiguity in how to classify it, in the end I decided to go with "bash" because I can say that all parts of that snippet are "shell text" but I can't say that all parts are "sql".
There was a problem hiding this comment.
Indeed, thanks for explaining this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes some broken links and tags code blocks with
jsonandbashwhere appropriate in the new tutorial/quickstart/api/configuration docs