Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: emoji encode error #131

Merged
merged 6 commits into from
Sep 20, 2019
Merged

Fix: emoji encode error #131

merged 6 commits into from
Sep 20, 2019

Conversation

wongoo
Copy link
Contributor

@wongoo wongoo commented Sep 17, 2019

What this PR does:
Fix emoji encode error

Which issue(s) this PR fixes:
Fixes #129

Special notes for your reviewer:
format code using:

goimports -w -l .
go fmt ./...

- Fix emoji encode error

@wongoo
Copy link
Contributor Author

wongoo commented Sep 19, 2019

@fangyincheng @pantianying @aliiohs @AlexStocks pls review

pantianying
pantianying approved these changes Sep 19, 2019
View reviewed changes
Copy link
Member

@pantianying pantianying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I test this code with some of my practical cases，and the results were in line with expectations.

@wongoo
Copy link
Contributor Author

wongoo commented Sep 19, 2019

I test this code with some of my practical cases，and the results were in line with expectations.

@pantianying thanks for testing

fangyincheng
fangyincheng approved these changes Sep 19, 2019
View reviewed changes
Copy link
Contributor

@fangyincheng fangyincheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@AlexStocks AlexStocks merged commit 548cd26 into apache:master Sep 20, 2019
@wongoo wongoo changed the title fix emoji encode error Fix: emoji encode error Oct 17, 2019
@zonghaishang zonghaishang mentioned this pull request May 16, 2020
Merged
zhaoyunxing92 pushed a commit that referenced this pull request Sep 4, 2021
@AlexStocks
Merge pull request #131 from wongoo/feature-emoji
92a2480 
fix emoji encode error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lovepoem lovepoem lovepoem left review comments

@pantianying pantianying pantianying approved these changes

@fangyincheng fangyincheng fangyincheng approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

fix:go emoji to java emoji（a character takes up 3-4 bytes of special symbols）
5 participants
@wongoo @lovepoem @fangyincheng @pantianying @AlexStocks