Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(filter): add sentinel samples. #706

Merged
merged 4 commits into from
Mar 14, 2024
Merged

feat(filter): add sentinel samples. #706

merged 4 commits into from
Mar 14, 2024

Conversation

r27153733
Copy link
Contributor

@chickenlj
Copy link
Contributor

Adding more sentinel use-cases would be better.

https://github.com/alibaba/sentinel-golang/tree/master/example

@chickenlj
Copy link
Contributor

Please fix the code formating issue.

@chickenlj
Copy link
Contributor

Please add this sample into integration test workflow by referencing this pr: #677

chickenlj
chickenlj approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@chickenlj chickenlj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Please add unit test for this sample with a new pull request later.

@chickenlj chickenlj merged commit 68fcddb into apache:main Mar 14, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chickenlj chickenlj chickenlj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@r27153733 @chickenlj