Merge pull request #944 from georgehao/develop

fix: URL.String() data race panic
apache · Dec 20, 2020 · daede0f · daede0f
1 parent 8031b43
commit daede0f
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/common/url.go b/common/url.go
@@ -317,6 +317,8 @@ func isMatchCategory(category1 string, category2 string) bool {
 }
 
 func (c *URL) String() string {
+	c.paramsLock.Lock()
+	defer c.paramsLock.Unlock()
 	var buf strings.Builder
 	if len(c.Username) == 0 && len(c.Password) == 0 {
 		buf.WriteString(fmt.Sprintf("%s://%s:%s%s?", c.Protocol, c.Ip, c.Port, c.Path))