Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: issue #951 etcd exit panic #1013

Merged
merged 2 commits into from
Jan 24, 2021

Conversation

watermelo
Copy link
Member

What this PR does:
Fix issue #951

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-io
Copy link

Codecov Report

Merging #1013 (dd1b395) into develop (0cb6edb) will decrease coverage by 0.05%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1013      +/-   ##
===========================================
- Coverage    59.66%   59.60%   -0.06%     
===========================================
  Files          261      261              
  Lines        12919    12921       +2     
===========================================
- Hits          7708     7702       -6     
- Misses        4240     4248       +8     
  Partials       971      971              
Impacted Files Coverage Δ
filter/filter_impl/sentinel_filter.go 63.04% <ø> (ø)
registry/nacos/registry.go 50.36% <57.14%> (-0.77%) ⬇️
registry/etcdv3/registry.go 64.15% <75.00%> (-0.77%) ⬇️
registry/etcdv3/listener.go 67.50% <100.00%> (+1.71%) ⬆️
remoting/etcdv3/listener.go 43.00% <100.00%> (ø)
registry/kubernetes/registry.go 51.11% <0.00%> (-8.89%) ⬇️
cluster/cluster_impl/failback_cluster_invoker.go 75.90% <0.00%> (+2.40%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9a666eb...dd1b395. Read the comment docs.

@AlexStocks AlexStocks added this to the v1.5.6 milestone Jan 24, 2021
@wenxuwan
Copy link
Member

LGTM

@cityiron cityiron modified the milestone: v1.5.6 Jan 24, 2021
@AlexStocks AlexStocks merged commit 9130466 into apache:develop Jan 24, 2021
AlexStocks added a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants