FIX:when connect to provider fail, will occur panic #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lop/github.com/dubbogo/gost-1.11.0 Bump github.com/dubbogo/gost from 1.10.1 to 1.11.0
wenxuwan
force-pushed
the
newestVersion
branch
from
e96efd6
to
17c4a9e
Compare
gaoxinge
approved these changes
Jan 27, 2021
Codecov Report
@@ Coverage Diff @@
## develop #1021 +/- ##
===========================================
+ Coverage 59.45% 59.48% +0.02%
===========================================
Files 261 261
Lines 12950 12960 +10
===========================================
+ Hits 7700 7709 +9
- Misses 4276 4278 +2
+ Partials 974 973 -1
Continue to review full report at Codecov.
|
AlexStocks
reviewed
Jan 27, 2021
| @@ -176,6 +176,8 @@ github.com/dubbogo/go-zookeeper v1.0.2/go.mod h1:fn6n2CAEer3novYgk9ULLwAjuV8/g4D | |||
| github.com/dubbogo/gost v1.9.0/go.mod h1:pPTjVyoJan3aPxBPNUX0ADkXjPibLo+/Ib0/fADXSG8= | |||
| github.com/dubbogo/gost v1.10.1 h1:39kF9Cd5JOiMpmwG6dX1/aLWNFqFv9gHp8HrhzMmjLY= | |||
| github.com/dubbogo/gost v1.10.1/go.mod h1:+mQGS51XQEUWZP2JeGZTxJwipjRKtJO7Tr+FOg+72rI= | |||
| github.com/dubbogo/gost v1.11.0 h1:9KtyWQz1gMlAfwzen5iyhMdoe08SPBBUVhco4rdgJ9I= | |||
| github.com/dubbogo/gost v1.11.0/go.mod h1:w8Yw29eDWtRVo3tx9nPpHkNZnOi4SRx1fZf7eVlAAU4= | |||
zouyx
approved these changes
Jan 28, 2021
zouyx
reviewed
Jan 28, 2021
| @@ -116,6 +117,7 @@ type Client struct { | |||
| addr string | |||
| opts Options | |||
| conf ClientConfig | |||
| mux sync.RWMutex | |||
There was a problem hiding this comment.
Why don't you use anonymous combination in this case?
There was a problem hiding this comment.
may be will add GetMux function to get lock of client
AlexStocks
approved these changes
Jan 30, 2021
AlexStocks
added a commit
that referenced
this pull request
Apr 14, 2021
FIX:when connect to provider fail, will occur panic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when connect to provider fail, buildInvokerChain function will occur panic
This Pr can fix #1014