Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade hession version #1088

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Conversation

wenxuwan
Copy link
Member

What this PR does:

Upgrade go-hession version

go.sum Outdated
@@ -117,6 +117,8 @@ github.com/apache/dubbo-go-hessian2 v1.8.2 h1:CQq2Mmlrk6Fqmudwl9Dqps8drTrBFnmXRl
github.com/apache/dubbo-go-hessian2 v1.8.2/go.mod h1:xQUjE7F8PX49nm80kChFvepA/AvqAZ0oh/UaB6+6pBE=
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

these history can be deleted

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, by the way, why we need delete these history ?

@codecov-io
Copy link

Codecov Report

Merging #1088 (9f359d0) into 1.5 (968650f) will decrease coverage by 0.52%.
The diff coverage is 60.26%.

❗ Current head 9f359d0 differs from pull request most recent head 15db1fc. Consider uploading reports for the commit 15db1fc to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              1.5    #1088      +/-   ##
==========================================
- Coverage   59.53%   59.01%   -0.53%     
==========================================
  Files         259      269      +10     
  Lines       12737    13123     +386     
==========================================
+ Hits         7583     7744     +161     
- Misses       4199     4410     +211     
- Partials      955      969      +14     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster.go 100.00% <ø> (ø)
cluster/cluster_impl/zone_aware_cluster_invoker.go 64.28% <ø> (ø)
cluster/router/healthcheck/factory.go 66.66% <0.00%> (ø)
cluster/router/tag/router_rule.go 89.47% <ø> (+12.20%) ⬆️
common/extension/config_post_processor.go 0.00% <0.00%> (ø)
common/extension/conn_checker.go 0.00% <0.00%> (ø)
common/extension/metadata_service.go 0.00% <0.00%> (ø)
common/proxy/proxy_factory/default.go 13.55% <0.00%> (+0.22%) ⬆️
config/base_config.go 64.02% <ø> (ø)
config/graceful_shutdown.go 54.28% <0.00%> (ø)
... and 173 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f74ff9...15db1fc. Read the comment docs.

@cityiron cityiron added this to the v1.5.6-rc2 milestone Mar 17, 2021
@cityiron cityiron merged commit 587753b into apache:1.5 Mar 17, 2021
AlexStocks pushed a commit that referenced this pull request Apr 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants