-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Imp: remote service discovery #1161
Merged
AlexStocks
merged 3,846 commits into
apache:3.0
from
Patrick0308:feature/3.0-service-discovery
Apr 19, 2021
Merged
Imp: remote service discovery #1161
AlexStocks
merged 3,846 commits into
apache:3.0
from
Patrick0308:feature/3.0-service-discovery
Apr 19, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rators Fix: fix zk listener func pathToKey
fix: RPCInvocation.ServiceKey use PATH_KEY instead of INTERFACE_KEY
AlexStocks
reviewed
Apr 19, 2021
} | ||
} | ||
|
||
// append Url params if we need it |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Url => URL
chickenlj
approved these changes
Apr 19, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
AlexStocks
approved these changes
Apr 19, 2021
LaurenceLiZhixin
approved these changes
Apr 19, 2021
AlexStocks
added a commit
that referenced
this pull request
Apr 20, 2021
Imp: remote service discovery
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
service discovery optimize