Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replace default config string with const value #1182

Merged
merged 2 commits into from
Apr 29, 2021

Conversation

Mulavar
Copy link
Member

@Mulavar Mulavar commented Apr 28, 2021

What this PR does:
replace default config string with const value

Which issue(s) this PR fixes:

Fixes #
none

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


Copy link
Member

@zouyx zouyx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you use exist key in this PR?

common/constant/default.go Outdated Show resolved Hide resolved
common/constant/default.go Outdated Show resolved Hide resolved
common/constant/default.go Outdated Show resolved Hide resolved
Copy link
Contributor

@zhaoyunxing92 zhaoyunxing92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved these changes

@AlexStocks AlexStocks merged commit ddc39a3 into apache:3.0 Apr 29, 2021
AlexStocks pushed a commit that referenced this pull request May 7, 2021
* add retry times

* Add: add ruubypay to user list. (#1180)

* fix import for linter

* replace default config string with const value (#1182)

* replace default config string with const value

* delete some duplicate keys

Co-authored-by: dongjianhui <dongjianhui@yuanfudao.com>

* Fix 3.0 ci problem (#1188)

* fix etcd problem

* fix metadata report etcd problem

* fix nacos & cluster_impl ci problem

* fix nacos ci problem

* fix zk ci problem

* fix zk metadata service urls not found error

* fix zk TestAddListenerZookeeperServiceDiscovery

* fix zk TestAddListenerZookeeperServiceDiscovery

* fix config int to string bug

* add retry times

* fix import for linter

* revert rename etcdv3

Co-authored-by: xianlezheng <zhengxianle@gmail.com>
Co-authored-by: Mulavar <978007503@qq.com>
Co-authored-by: dongjianhui <dongjianhui@yuanfudao.com>
Co-authored-by: randy <ztelur@gmail.com>
Co-authored-by: 蒋超 <jiangchao@jiangchaodeMacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants