Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tst: Add unit tests for app metadata reporter of zookeeper #1229

Merged
merged 2 commits into from
Jun 2, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
50 changes: 41 additions & 9 deletions metadata/report/zookeeper/report_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ func newServiceMetadataIdentifier(side string) *identifier.ServiceMetadataIdenti
}
}

func newSubscribeMetadataIdentifier(side string) *identifier.SubscriberMetadataIdentifier {
func newSubscribeMetadataIdentifier() *identifier.SubscriberMetadataIdentifier {
return &identifier.SubscriberMetadataIdentifier{
Revision: "1.0",
BaseApplicationMetadataIdentifier: identifier.BaseApplicationMetadataIdentifier{Application: "provider"},
Expand Down Expand Up @@ -120,15 +120,15 @@ func (suite *zookeeperMetadataReportTestSuite) testGetExportedURLs() {
}

func (suite *zookeeperMetadataReportTestSuite) testSaveSubscribedData(url *common.URL) {
subscribeMi := newSubscribeMetadataIdentifier("provider")
subscribeMi := newSubscribeMetadataIdentifier()
urls := []string{url.String()}
bytes, _ := json.Marshal(urls)
err := suite.m.SaveSubscribedData(subscribeMi, string(bytes))
assert.Nil(suite.t, err)
}

func (suite *zookeeperMetadataReportTestSuite) testGetSubscribedURLs() {
subscribeMi := newSubscribeMetadataIdentifier("provider")
subscribeMi := newSubscribeMetadataIdentifier()
urls, err := suite.m.GetSubscribedURLs(subscribeMi)
assert.Equal(suite.t, 1, len(urls))
assert.NoError(suite.t, err)
Expand All @@ -141,31 +141,63 @@ func (suite *zookeeperMetadataReportTestSuite) testGetServiceDefinition() {
assert.NoError(suite.t, err)
}

func test1(t *testing.T) {
func (suite *zookeeperMetadataReportTestSuite) testPublishAppMetadata() {
subscribeMi := newSubscribeMetadataIdentifier()
info := common.NewMetadataInfWithApp(subscribeMi.Application)
err := suite.m.PublishAppMetadata(subscribeMi, info)
assert.NoError(suite.t, err)
}

func (suite *zookeeperMetadataReportTestSuite) testGetAppMetadata() {
subscribeMi := newSubscribeMetadataIdentifier()
info, err := suite.m.GetAppMetadata(subscribeMi)
assert.NoError(suite.t, err)
assert.Equal(suite.t, "provider", info.App)
}

func testInterfaceMetadata(t *testing.T) {
testCluster, err := zk.StartTestCluster(1, nil, nil, zk.WithRetryTimes(20))
assert.NoError(t, err)
defer func() {
err := testCluster.Stop()
assert.Nil(t, err)
}()

url := newProviderRegistryUrl("127.0.0.1", testCluster.Servers[0].Port)
providerRegistryUrl := newProviderRegistryUrl("127.0.0.1", testCluster.Servers[0].Port)
mf := extension.GetMetadataReportFactory("zookeeper")
m := mf.CreateMetadataReport(url)
m := mf.CreateMetadataReport(providerRegistryUrl)

suite := newZookeeperMetadataReportTestSuite(t, m)
suite.testStoreProviderMetadata()
suite.testStoreConsumerMetadata()
suite.testSaveServiceMetadata(url)
suite.testSaveServiceMetadata(providerRegistryUrl)
suite.testGetExportedURLs()
suite.testRemoveServiceMetadata()
suite.testSaveSubscribedData(url)
suite.testSaveSubscribedData(providerRegistryUrl)
suite.testGetSubscribedURLs()
suite.testGetServiceDefinition()
}

func testAppMetadata(t *testing.T) {
testCluster, err := zk.StartTestCluster(1, nil, nil, zk.WithRetryTimes(20))
assert.NoError(t, err)
defer func() {
err := testCluster.Stop()
assert.Nil(t, err)
}()

providerRegistryUrl := newProviderRegistryUrl("127.0.0.1", testCluster.Servers[0].Port)
mf := extension.GetMetadataReportFactory("zookeeper")
m := mf.CreateMetadataReport(providerRegistryUrl)

suite := newZookeeperMetadataReportTestSuite(t, m)
suite.testPublishAppMetadata()
suite.testGetAppMetadata()
}

// TestZookeeperMetadataReport is dependent on zookeeper-*-fatjar.jar,
// please execute `make -f ../../../Makefile prepare` before running unittest.
func TestZookeeperMetadataReport(t *testing.T) {
t.Run("test1", test1)
t.Run("testInterfaceMetadata", testInterfaceMetadata)
t.Run("testAppMetadata", testAppMetadata)
}