Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: metadata info change #1234

Merged

Conversation

LaurenceLiZhixin
Copy link
Contributor

What this PR does:
之前的情况会导致local模式的应用级服务发现失败,因为在local模式服务自省过程中传递的结构体common.MetadataInfo存在无法通过hessian2序列化的atomic.Bool结构,经过修改后即可。且该字段只在服务暴露时写入一次,无需使用原子操作。

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

Codecov Report

Merging #1234 (29b80ab) into 3.0 (968650f) will decrease coverage by 3.56%.
The diff coverage is 50.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1234      +/-   ##
==========================================
- Coverage   59.53%   55.97%   -3.57%     
==========================================
  Files         259      272      +13     
  Lines       12737    12883     +146     
==========================================
- Hits         7583     7211     -372     
- Misses       4199     4776     +577     
+ Partials      955      896      -59     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
...router/v3router/judger/list_string_match_judger.go 0.00% <0.00%> (ø)
...ster/router/v3router/judger/method_match_judger.go 0.00% <0.00%> (ø)
...er/router/v3router/judger/url_label_match_judge.go 0.00% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d32458b...29b80ab. Read the comment docs.

@LaurenceLiZhixin
Copy link
Contributor Author

但是在与Java进行local模式互通的时候,除了上述问题,还存在序列化方式、传输结构未对齐的问题。所以目前local模式的应用级服务发现还只限于go互通。

@wongoo
Copy link
Contributor

wongoo commented Jun 2, 2021

LGTM

@LaurenceLiZhixin LaurenceLiZhixin merged commit fab79fa into apache:3.0 Jun 3, 2021
@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0-rc2 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants