Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: URL serialization bug #1238

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Fix: URL serialization bug #1238

merged 3 commits into from
Jun 7, 2021

Conversation

justxuewei
Copy link
Member

What this PR does:

  • register URL as a POJO instance
  • add error handling for hessian2 serializer

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@codecov-commenter
Copy link

Codecov Report

Merging #1238 (0ab2502) into 3.0 (968650f) will decrease coverage by 3.64%.
The diff coverage is 50.56%.

❗ Current head 0ab2502 differs from pull request most recent head 0865622. Consider uploading reports for the commit 0865622 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1238      +/-   ##
==========================================
- Coverage   59.53%   55.88%   -3.65%     
==========================================
  Files         259      272      +13     
  Lines       12737    12895     +158     
==========================================
- Hits         7583     7207     -376     
- Misses       4199     4788     +589     
+ Partials      955      900      -55     
Impacted Files Coverage Δ
cluster/cluster_impl/available_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/broadcast_cluster_invoker.go 76.47% <ø> (ø)
cluster/cluster_impl/failfast_cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster_impl/mock_cluster.go 0.00% <0.00%> (ø)
cluster/loadbalance/random.go 100.00% <ø> (ø)
...router/v3router/judger/list_string_match_judger.go 0.00% <0.00%> (ø)
...ster/router/v3router/judger/method_match_judger.go 0.00% <0.00%> (ø)
...er/router/v3router/judger/url_label_match_judge.go 0.00% <0.00%> (ø)
common/extension/auth.go 0.00% <ø> (ø)
common/extension/cluster.go 0.00% <ø> (ø)
... and 275 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b5cd555...0865622. Read the comment docs.

Copy link
Contributor

@zhaoyunxing92 zhaoyunxing92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved these changes

@AlexStocks AlexStocks merged commit 16d8297 into apache:3.0 Jun 7, 2021
@justxuewei justxuewei deleted the fix/hessian branch June 10, 2021 05:42
@LaurenceLiZhixin LaurenceLiZhixin added this to the v3.0.0-rc2 milestone Jun 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants