Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Key generate Func in ServiceEvent #1286

Merged
merged 4 commits into from
Jul 11, 2021
Merged

Support Key generate Func in ServiceEvent #1286

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ba4c7cf
support Key Func in ServiceEvent
cvictory Jun 29, 2021
3cbda80
FIX review issue and add unit test
cvictory Jun 29, 2021
bd95032
fix : make all getCacheKey from ServiceEvent
cvictory Jun 29, 2021
ba494dd
fix override url notify bug
cvictory Jun 30, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion registry/event.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ type ServiceEvent struct {
key string
// If the url is updated, such as Merged.
updated bool
KeyFunc func(*common.URL) string
cvictory marked this conversation as resolved.
Show resolved Hide resolved
}

// String return the description of event
Expand All @@ -69,7 +70,11 @@ func (e *ServiceEvent) Key() string {
if len(e.key) > 0 {
return e.key
}
e.key = e.Service.GetCacheInvokerMapKey()
if e.KeyFunc == nil {
e.key = e.Service.GetCacheInvokerMapKey()
} else {
e.key = e.KeyFunc(e.Service)
}
return e.key
}

Expand Down