Ftr: etcdv3 for registry #148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 23 commits
July 19, 2019 16:45
added 4 commits
August 3, 2019 12:22
fangyincheng
reviewed
Aug 3, 2019
Codecov Report
@@ Coverage Diff @@
## develop #148 +/- ##
===========================================
- Coverage 69.26% 66.19% -3.07%
===========================================
Files 81 86 +5
Lines 4656 5260 +604
===========================================
+ Hits 3225 3482 +257
- Misses 1116 1414 +298
- Partials 315 364 +49
Continue to review full report at Codecov.
|
fangyincheng
reviewed
Aug 3, 2019
AlexStocks
reviewed
Aug 3, 2019
hxmhlt
approved these changes
Aug 3, 2019
hxmhlt
reviewed
Aug 3, 2019
hxmhlt
reviewed
Aug 3, 2019
fangyincheng
reviewed
Aug 4, 2019
AlexStocks
reviewed
Aug 10, 2019
|
LGTM |
hxmhlt
reviewed
Aug 12, 2019
LaurenceLiZhixin
pushed a commit
to LaurenceLiZhixin/dubbo-go
that referenced
this pull request
Jul 17, 2021
* fix: seata panic , attachment to AttachmentKey * update: the standard of import dependency Co-authored-by: yuefengbo <yuefengbo@meituan.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Ftr: etcdv3 for registry
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
remoting pkg unit test is done, see ./remoting/etcdv3/*_test.go
registry pkg unit test is done, see ./registry/etcdv3/*_test.go
Does this PR introduce a user-facing change?: