Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

metadata mapping reported using registry config #1611

Merged
merged 1 commit into from
Nov 26, 2021

Conversation

binbin0325
Copy link
Member

What this PR does:
local mode, metadata mapping is reported using registration information
Which issue(s) this PR fixes:

Fixes #1610

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@LaurenceLiZhixin
Copy link
Contributor

LaurenceLiZhixin commented Nov 23, 2021

需要在config pkg下增加 import _ "xxx/metadata-report/nacos" 类似的依赖,保证单测通过 @sanxun0325

@codecov-commenter
Copy link

codecov-commenter commented Nov 23, 2021

Codecov Report

Merging #1611 (dd0efbf) into 3.0 (cc201e9) will decrease coverage by 0.26%.
The diff coverage is 27.37%.

❗ Current head dd0efbf differs from pull request most recent head 9ccc69f. Consider uploading reports for the commit 9ccc69f to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1611      +/-   ##
==========================================
- Coverage   41.20%   40.93%   -0.27%     
==========================================
  Files         250      252       +2     
  Lines       14264    14441     +177     
==========================================
+ Hits         5877     5912      +35     
- Misses       7703     7848     +145     
+ Partials      684      681       -3     
Impacted Files Coverage Δ
common/rpc_service.go 87.43% <ø> (ø)
config/config_loader.go 13.69% <0.00%> (-0.39%) ⬇️
config/consumer_config.go 21.42% <0.00%> (-3.32%) ⬇️
config/metadata_report_config.go 22.50% <0.00%> (-0.29%) ⬇️
config/reference_config.go 0.00% <0.00%> (ø)
config/tracing_config.go 0.00% <0.00%> (ø)
filter/accesslog/filter.go 32.77% <0.00%> (-0.57%) ⬇️
remoting/zookeeper/listener.go 0.00% <0.00%> (ø)
config/provider_config.go 19.58% <7.69%> (-5.07%) ⬇️
protocol/dubbo3/dubbo3_protocol.go 59.01% <14.28%> (-9.26%) ⬇️
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03cf5fd...9ccc69f. Read the comment docs.

@binbin0325 binbin0325 force-pushed the 3.0_matedata branch 2 times, most recently from ffb0ba8 to dd0efbf Compare November 24, 2021 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants