Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: attachments maybe nil or empty string #1631

Merged
merged 1 commit into from
Dec 3, 2021

Conversation

PhilYue
Copy link
Member

@PhilYue PhilYue commented Dec 2, 2021

What this PR does:

Unmarshal request body by hession.go , the attribute attachments maybe nil or empty string, and will stop the invoked

Which issue(s) this PR fixes:

if attachments nil or empty string , default a value that for normal invoking

Fixes #1583

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@PhilYue
Copy link
Member Author

PhilYue commented Dec 2, 2021

#1583

@codecov-commenter
Copy link

Codecov Report

Merging #1631 (0d5ed1f) into 3.0 (f7f1581) will decrease coverage by 0.08%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1631      +/-   ##
==========================================
- Coverage   41.10%   41.02%   -0.09%     
==========================================
  Files         253      253              
  Lines       14498    14498              
==========================================
- Hits         5960     5948      -12     
- Misses       7848     7861      +13     
+ Partials      690      689       -1     
Impacted Files Coverage Δ
protocol/dubbo/impl/hessian.go 31.23% <0.00%> (ø)
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-7.95%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f7f1581...0d5ed1f. Read the comment docs.

@AlexStocks AlexStocks merged commit 78ca361 into apache:3.0 Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants