Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

3.0 support set nacos ContextPath #1656

Merged
merged 1 commit into from
Dec 10, 2021
Merged

3.0 support set nacos ContextPath #1656

merged 1 commit into from
Dec 10, 2021

Conversation

binbin0325
Copy link
Member

What this PR does:
support set nacos context path
Which issue(s) this PR fixes:

Fixes ##1653

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

# registry config
registries:
  "demoNacos":
    protocol: "nacos"
    timeout	: "3s"
    address: "127.0.0.1:8848" or. "127.0.0.1:8848/nacos"

Mulavar
Mulavar reviewed Dec 10, 2021
View reviewed changes
remoting/nacos/builder.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit d411e11 into apache:3.0 Dec 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhaoyunxing92 zhaoyunxing92 zhaoyunxing92 left review comments

@cjphaha cjphaha cjphaha approved these changes

@Mulavar Mulavar Mulavar approved these changes

@AlexStocks AlexStocks AlexStocks approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@binbin0325 @AlexStocks @zhaoyunxing92 @Mulavar @cjphaha