Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor zk dynamic configuration listener #1665

Merged
merged 1 commit into from
Jan 12, 2022

Conversation

Mulavar
Copy link
Member

@Mulavar Mulavar commented Dec 13, 2021

What this PR does:

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@codecov-commenter
Copy link

codecov-commenter commented Dec 13, 2021

Codecov Report

Merging #1665 (2909c83) into 3.0 (c4fa4a0) will decrease coverage by 0.21%.
The diff coverage is 3.07%.

❗ Current head 2909c83 differs from pull request most recent head 77f3730. Consider uploading reports for the commit 77f3730 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1665      +/-   ##
==========================================
- Coverage   41.36%   41.15%   -0.22%     
==========================================
  Files         255      254       -1     
  Lines       14664    14621      -43     
==========================================
- Hits         6066     6017      -49     
- Misses       7899     7905       +6     
  Partials      699      699              
Impacted Files Coverage Δ
config/consumer_config.go 21.42% <0.00%> (ø)
remoting/zookeeper/client.go 0.00% <0.00%> (ø)
remoting/zookeeper/listener.go 0.00% <0.00%> (ø)
cluster/router/v3router/router_chain.go 39.39% <12.50%> (-2.41%) ⬇️
config/root_config.go 40.93% <0.00%> (-5.52%) ⬇️
...tocol/rest/server/server_impl/go_restful_server.go 41.37% <0.00%> (-3.45%) ⬇️
config/registry_config.go 18.84% <0.00%> (-1.67%) ⬇️
cluster/cluster/base/cluster_invoker.go 24.17% <0.00%> (-0.27%) ⬇️
common/url.go 61.03% <0.00%> (-0.10%) ⬇️
protocol/result.go 0.00% <0.00%> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c4fa4a0...77f3730. Read the comment docs.

@Mulavar Mulavar changed the title [WIP]refactor zk dynamic configuration listener refactor zk dynamic configuration listener Dec 16, 2021
@LaurenceLiZhixin
Copy link
Contributor

@Mulavar Check Conflict and I would merge it.

@Mulavar
Copy link
Member Author

Mulavar commented Jan 7, 2022

@Mulavar Check Conflict and I would merge it.

finished, thanks.

Copy link
Member

@binbin0325 binbin0325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AlexStocks AlexStocks merged commit 20e6451 into apache:3.0 Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants