Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #1687] Fix the problem that the heartbeat cannot be reported #1688

Merged
merged 4 commits into from
Jan 7, 2022

Conversation

chuntaojun
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:

Fixes #1687

Special notes for your reviewer:

Does this PR introduce a user-facing change?:


@chuntaojun chuntaojun changed the base branch from master to 3.0 December 27, 2021 02:12
@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2021

Codecov Report

Merging #1688 (7801449) into 3.0 (6710138) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              3.0    #1688      +/-   ##
==========================================
+ Coverage   41.35%   41.37%   +0.02%     
==========================================
  Files         255      255              
  Lines       14664    14664              
==========================================
+ Hits         6064     6067       +3     
+ Misses       7901     7899       -2     
+ Partials      699      698       -1     
Impacted Files Coverage Δ
filter/metrics/filter.go 100.00% <0.00%> (+15.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6710138...7801449. Read the comment docs.

@justxuewei
Copy link
Member

Please perform go fmt ./... on your local environment, and push the code again to pass the CI.

@LaurenceLiZhixin LaurenceLiZhixin merged commit 66b43aa into apache:3.0 Jan 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When using the Polaris registry, InstanceRegisterRequest needs to set the value of the TTL field
7 participants