Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor json rpc request timeout #1713

Merged
merged 1 commit into from
Jan 16, 2022

Conversation

sunrui1225
Copy link
Contributor

What this PR does: make the jsonrpc protocol request timeout can be read from consumer config . The read order of requestTimeout is from url , if nil then from consumer config , if nil then default 3s. requestTimeout can be dynamically updated from config center.

Which issue(s) this PR fixes:
Fixes #1584

@codecov-commenter
Copy link

Codecov Report

Merging #1713 (a4f044a) into 3.0 (20e6451) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head a4f044a differs from pull request most recent head 8706cae. Consider uploading reports for the commit 8706cae to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##              3.0    #1713   +/-   ##
=======================================
  Coverage   41.29%   41.30%           
=======================================
  Files         255      255           
  Lines       14705    14703    -2     
=======================================
  Hits         6073     6073           
+ Misses       7933     7931    -2     
  Partials      699      699           
Impacted Files Coverage Δ
protocol/jsonrpc/jsonrpc_protocol.go 95.74% <100.00%> (-0.18%) ⬇️
...tocol/rest/server/server_impl/go_restful_server.go 44.82% <0.00%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 20e6451...8706cae. Read the comment docs.

@LaurenceLiZhixin
Copy link
Contributor

@PhilYue

@AlexStocks AlexStocks merged commit 08e4387 into apache:3.0 Jan 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants