Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

graceful pr refine #1731

Merged
merged 1 commit into from
Feb 1, 2022
Merged

graceful pr refine #1731

merged 1 commit into from
Feb 1, 2022

Conversation

binbin0325
Copy link
Member

What this PR does:
refine graceful pr:#1675
Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@justxuewei
Copy link
Member

Please follow dubbogo 3-block import style.

@binbin0325
Copy link
Member Author

Please follow dubbogo 3-block import style.

大佬请指教,我这里用tool 不好用,可以指点一下 我这个导入应该怎么改么

@AlexStocks AlexStocks merged commit 3d09243 into apache:3.0 Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants