Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adasvc): do not use adaptive service filter if disabled on the client side #1748

Merged

Conversation

justxuewei
Copy link
Member

@justxuewei justxuewei commented Feb 11, 2022

What this PR does:

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@justxuewei justxuewei changed the title fix(adasvc): do not use adaptive service filter if disabled on the cl… fix(adasvc): do not use adaptive service filter if disabled on the client side Feb 11, 2022
@justxuewei justxuewei force-pushed the fix/adasvc/disabled-on-client-side branch from 461b7db to 694f914 Compare February 11, 2022 08:53
@AlexStocks AlexStocks merged commit 1cc4bcc into apache:3.0 Feb 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants