-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: decode net stream bytes as getty rule #1820
Conversation
Codecov Report
@@ Coverage Diff @@
## 3.0 #1820 +/- ##
==========================================
- Coverage 46.85% 46.75% -0.11%
==========================================
Files 298 298
Lines 17163 17178 +15
==========================================
- Hits 8042 8031 -11
- Misses 8275 8293 +18
- Partials 846 854 +8
Continue to review full report at Codecov.
|
a2869eb
to
bbe817c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please fix ci failure
pls do not merge this pr |
6f29aed
to
18a6f94
Compare
18a6f94
to
c6d896e
Compare
c6d896e
to
b4558b6
Compare
fix: fix unit test
LGTM |
What this PR does:
the current dubbo-go do not follow the getty rule when decoding tcp network streams
Which issue(s) this PR fixes:
Fixes #
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed