Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

xds ring hash #1828

Merged
merged 2 commits into from
Apr 30, 2022
Merged

xds ring hash #1828

merged 2 commits into from
Apr 30, 2022

Conversation

binbin0325
Copy link
Member

What this PR does:

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Apr 11, 2022

Codecov Report

Merging #1828 (f22ac49) into 3.0 (7bc593b) will increase coverage by 0.04%.
The diff coverage is 69.56%.

@@            Coverage Diff             @@
##              3.0    #1828      +/-   ##
==========================================
+ Coverage   46.85%   46.90%   +0.04%     
==========================================
  Files         298      300       +2     
  Lines       17163    17293     +130     
==========================================
+ Hits         8042     8111      +69     
- Misses       8275     8321      +46     
- Partials      846      861      +15     
Impacted Files Coverage Δ
remoting/xds/client.go 52.94% <0.00%> (-3.95%) ⬇️
cluster/loadbalance/ringhash/ringhash.go 63.33% <63.33%> (ø)
cluster/loadbalance/ringhash/ring.go 84.50% <84.50%> (ø)
remoting/xds/ewatcher/ewatcher.go 100.00% <100.00%> (ø)
...tocol/rest/server/server_impl/go_restful_server.go 41.37% <0.00%> (-3.45%) ⬇️
remoting/getty/readwriter.go 39.28% <0.00%> (-3.31%) ⬇️
registry/nacos/listener.go 78.26% <0.00%> (-2.61%) ⬇️
metrics/prometheus/reporter.go 26.85% <0.00%> (-1.72%) ⬇️
protocol/dubbo/impl/codec.go 41.66% <0.00%> (-0.55%) ⬇️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7bc593b...f22ac49. Read the comment docs.

@AlexStocks
Copy link
Contributor

@sanxun0325 整体我觉得没啥问题,注意下 ut 覆盖率。

@AlexStocks AlexStocks merged commit 8b3b71e into apache:3.0 Apr 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants