Tst:mock etcd and nacos in ut #1873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comment for blank (apache#1755)
Codecov Report
@@ Coverage Diff @@
## 3.0 #1873 +/- ##
==========================================
- Coverage 46.80% 45.12% -1.69%
==========================================
Files 295 295
Lines 17178 17178
==========================================
- Hits 8041 7751 -290
- Misses 8285 8595 +310
+ Partials 852 832 -20
Continue to review full report at Codecov.
|
AlexStocks
reviewed
Apr 30, 2022
AlexStocks
reviewed
Apr 30, 2022
config_center/nacos/impl_test.go
Outdated
| } | ||
| type args struct { | ||
| group string | ||
| } |
AlexStocks
reviewed
Apr 30, 2022
config_center/nacos/impl_test.go
Outdated
| client: tt.fields.client, | ||
| keyListeners: tt.fields.keyListeners, | ||
| parser: tt.fields.parser, | ||
| } |
There was a problem hiding this comment.
如果 n 和 tt.fields 类型相同，则可以这么写：
n := &nacosDynamicConfiguration{}
*n = tt.fields
不行就封装一个函数出来，我看你别的地方也有类似的逻辑，写一个函数也好复用。
AlexStocks
reviewed
Apr 30, 2022
registry/etcdv3/registry_test.go
Outdated
| listenerLock: tt.fields.listenerLock, | ||
| listener: tt.fields.listener, | ||
| dataListener: tt.fields.dataListener, | ||
| configListener: tt.fields.configListener, |
AlexStocks
approved these changes
May 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
mock etcd and nacos in ut
Which issue(s) this PR fixes:
Fixes #
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed