Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: export method getArgsTypeList for extension #1913

Merged
merged 1 commit into from
May 31, 2022

Conversation

LaurenceLiZhixin
Copy link
Contributor

@LaurenceLiZhixin LaurenceLiZhixin commented May 31, 2022

What this PR does:

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

Codecov Report

Merging #1913 (e5e2efa) into 3.0 (a0528f2) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              3.0    #1913   +/-   ##
=======================================
  Coverage   44.95%   44.95%           
=======================================
  Files         287      287           
  Lines       17130    17130           
=======================================
  Hits         7701     7701           
- Misses       8616     8617    +1     
+ Partials      813      812    -1     
Impacted Files Coverage Δ
protocol/dubbo/impl/hessian.go 32.88% <100.00%> (ø)
metrics/prometheus/reporter.go 33.33% <0.00%> (-1.70%) ⬇️
filter/metrics/filter.go 100.00% <0.00%> (+15.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0528f2...e5e2efa. Read the comment docs.

@AlexStocks AlexStocks merged commit 9bc111e into 3.0 May 31, 2022
@justxuewei justxuewei deleted the export-hessian-type-api branch September 8, 2022 06:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants