Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add: invoker & attachments & merge master #193

Merged
merged 27 commits into from
Sep 10, 2019

Conversation

fangyincheng
Copy link
Contributor

What this PR does:

  1. move callService to invoker;
  2. complete attachments;
  3. merge master;
  4. upgrade hessian2

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

@codecov-io
Copy link

codecov-io commented Sep 6, 2019

Codecov Report

Merging #193 into develop will decrease coverage by 0.09%.
The diff coverage is 43.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop     #193     +/-   ##
==========================================
- Coverage    66.71%   66.62%   -0.1%     
==========================================
  Files           94       94             
  Lines         5870     5818     -52     
==========================================
- Hits          3916     3876     -40     
+ Misses        1545     1540      -5     
+ Partials       409      402      -7
Impacted Files Coverage Δ
protocol/dubbo/dubbo_protocol.go 95.55% <ø> (ø) ⬆️
protocol/dubbo/dubbo_invoker.go 82.92% <100%> (+0.87%) ⬆️
protocol/dubbo/codec.go 76.47% <100%> (+2.94%) ⬆️
filter/impl/echo_filter.go 85.71% <100%> (+1.09%) ⬆️
registry/protocol/protocol.go 75% <25%> (-1.54%) ⬇️
common/proxy/proxy_factory/default.go 18.33% <3.92%> (-81.67%) ⬇️
protocol/dubbo/listener.go 50% <36.36%> (-4.17%) ⬇️
protocol/dubbo/readwriter.go 69.23% <50%> (-2.57%) ⬇️
protocol/jsonrpc/server.go 59.79% <50%> (+7.89%) ⬆️
protocol/dubbo/client.go 70.94% <96.29%> (+2.56%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 359bdab...ddcf560. Read the comment docs.

@AlexStocks AlexStocks changed the title invoker & attachments & merge master Add: invoker & attachments & merge master Sep 7, 2019
common/constant/env.go Outdated Show resolved Hide resolved
common/proxy/proxy_factory/default.go Show resolved Hide resolved
common/proxy/proxy_factory/default.go Show resolved Hide resolved
protocol/dubbo/readwriter.go Outdated Show resolved Hide resolved
protocol/dubbo/readwriter.go Outdated Show resolved Hide resolved
registry/protocol/protocol.go Outdated Show resolved Hide resolved
@AlexStocks AlexStocks merged commit e5d1247 into apache:develop Sep 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants