Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ftr] Enhance ServiceDefinition in MetadataService #1963

Merged
merged 7 commits into from
Aug 10, 2022
Merged

[Ftr] Enhance ServiceDefinition in MetadataService #1963

merged 7 commits into from
Aug 10, 2022

Conversation

Leospard
Copy link
Contributor

@Leospard Leospard commented Jul 10, 2022 •
edited
Loading

What this PR does:
Enhance ServiceDefinition in MetadataService, which means provide full parameters in Servicedefinition.

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@Leospard Leospard changed the base branch from master to 3.0 July 10, 2022 04:18
@AlexStocks
Copy link
Contributor

pls fix the ci failure.

@codecov-commenter
Copy link

codecov-commenter commented Jul 19, 2022 •
edited
Loading

Codecov Report

Merging #1963 (bdbd248) into 3.0 (026711b) will decrease coverage by 0.36%.
The diff coverage is 52.30%.

@@            Coverage Diff             @@
##              3.0    #1963      +/-   ##
==========================================
- Coverage   44.96%   44.59%   -0.37%     
==========================================
  Files         287      283       -4     
  Lines       17135    17101      -34     
==========================================
- Hits         7704     7626      -78     
- Misses       8618     8670      +52     
+ Partials      813      805       -8
Impacted Files Coverage Δ
cluster/cluster/base/cluster_invoker.go 24.44% <ø> (ø)
cluster/cluster/broadcast/cluster_invoker.go 80.00% <ø> (ø)
cluster/cluster/failback/cluster_invoker.go 75.82% <ø> (ø)
cluster/cluster/failover/cluster_invoker.go 66.66% <ø> (ø)
cluster/cluster/failsafe/cluster_invoker.go 81.81% <ø> (ø)
cluster/cluster/forking/cluster_invoker.go 58.33% <ø> (ø)
cluster/loadbalance/p2c/loadbalance.go 80.00% <ø> (+3.63%) ⬆️
cluster/loadbalance/ringhash/ringhash.go 63.33% <ø> (ø)
cluster/router/tag/match.go 90.69% <ø> (ø)
cluster/router/tag/router.go 59.64% <ø> (ø)
... and 142 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

cjphaha
cjphaha reviewed Jul 19, 2022
View reviewed changes
metadata/service/local/service.go Outdated Show resolved Hide resolved
metadata/service/remote/service.go Outdated Show resolved Hide resolved
metadata/definition/definition.go Show resolved Hide resolved
@Leospard Leospard changed the title [WIP] Enhance ServiceDefinition in MetadataService [Ftr] Enhance ServiceDefinition in MetadataService Jul 29, 2022
@AlexStocks AlexStocks merged commit 267036a into apache:3.0 Aug 10, 2022
CoolIceV pushed a commit to CoolIceV/dubbo-go that referenced this pull request Aug 31, 2022
@Leospard @CoolIceV
[Ftr] Enhance ServiceDefinition in MetadataService (apache#1963)
01b31db 
* Add FullServiceDefinition struct

* mark the place waiting to be changed in PublishServiceDefinition

* add test about FullServiceDefinition

* modify format

* modify comment

* format the code

* split one long line
CoolIceV added a commit to CoolIceV/dubbo-go that referenced this pull request Sep 9, 2022
@CoolIceV @dependabot
@zhaoyunxing92 @Leospard @AlexStocks
Adaptive service (#2)
75f5bb8 
* feat(adaptive service): auto concurrency limiter

* feat(adaptive service): auto concurrency limiter

* feat(adaptive service): auto concurrency limiter

* feat(adaptive service): auto concurrency limiter

* feat(adaptive service): auto concurrency limiter

* feat(adaptive service): p2c weight

* build(deps): bump go.opentelemetry.io/otel/trace from 1.8.0 to 1.9.0 (apache#2010)

Bumps [go.opentelemetry.io/otel/trace](https://github.com/open-telemetry/opentelemetry-go) from 1.8.0 to 1.9.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.8.0...v1.9.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel/trace
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump go.opentelemetry.io/otel from 1.8.0 to 1.9.0 (apache#2013)

Bumps [go.opentelemetry.io/otel](https://github.com/open-telemetry/opentelemetry-go) from 1.8.0 to 1.9.0.
- [Release notes](https://github.com/open-telemetry/opentelemetry-go/releases)
- [Changelog](https://github.com/open-telemetry/opentelemetry-go/blob/main/CHANGELOG.md)
- [Commits](open-telemetry/opentelemetry-go@v1.8.0...v1.9.0)

---
updated-dependencies:
- dependency-name: go.opentelemetry.io/otel
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* build(deps): bump github.com/nacos-group/nacos-sdk-go (apache#2012)

Bumps [github.com/nacos-group/nacos-sdk-go](https://github.com/nacos-group/nacos-sdk-go) from 1.1.1 to 1.1.2.
- [Release notes](https://github.com/nacos-group/nacos-sdk-go/releases)
- [Commits](nacos-group/nacos-sdk-go@v1.1.1...v1.1.2)

---
updated-dependencies:
- dependency-name: github.com/nacos-group/nacos-sdk-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* fix(shotdown):fix shotdown InternalSignal default value

* test(shutdown):add shutdown internal signal test

* [Ftr] Enhance ServiceDefinition in MetadataService (apache#1963)

* Add FullServiceDefinition struct

* mark the place waiting to be changed in PublishServiceDefinition

* add test about FullServiceDefinition

* modify format

* modify comment

* format the code

* split one long line

* ignore goenv

* build(deps): bump github.com/dubbogo/grpc-go from 1.42.9 to 1.42.10 (apache#2019)

Bumps [github.com/dubbogo/grpc-go](https://github.com/dubbogo/grpc-go) from 1.42.9 to 1.42.10.
- [Release notes](https://github.com/dubbogo/grpc-go/releases)
- [Commits](dubbogo/grpc-go@v1.42.9...v1.42.10)

---
updated-dependencies:
- dependency-name: github.com/dubbogo/grpc-go
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* upgrade grpc-go version v1.42.9 -> v1.42.10 (apache#2017)

* Revert 2014 resolve placeholder (apache#2023)

* resolve placeholder

* build(deps): bump github.com/knadh/koanf from 1.4.2 to 1.4.3 (apache#2027)

Bumps [github.com/knadh/koanf](https://github.com/knadh/koanf) from 1.4.2 to 1.4.3.
- [Release notes](https://github.com/knadh/koanf/releases)
- [Commits](knadh/koanf@v1.4.2...v1.4.3)

---
updated-dependencies:
- dependency-name: github.com/knadh/koanf
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* feat(adaptive service): p2c weight

* feat(adaptive service): ema

* fix license

* fix time

* auto concurrency limiter

* auto concurrency limiter

* auto concurrency limiter

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: zhaoyunxing <zhaoyunxing@apache.org>
Co-authored-by: Leo Shen <40532785+Leospard@users.noreply.github.com>
Co-authored-by: AlexStocks <alexstocks@foxmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjphaha cjphaha cjphaha left review comments

@AlexStocks AlexStocks AlexStocks approved these changes

@justxuewei justxuewei justxuewei approved these changes

@zhaoyunxing92 zhaoyunxing92 zhaoyunxing92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@Leospard @AlexStocks @codecov-commenter @justxuewei @zhaoyunxing92 @cjphaha