Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: route with more invokers #2000

Merged
merged 1 commit into from
Aug 2, 2022

Conversation

Lvnszn
Copy link
Contributor

@Lvnszn Lvnszn commented Jul 30, 2022

What this PR does:
multiple invoker may include different methods, find correct invoker.

image

Which issue(s) this PR fixes:
Fixes #1956

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@AlexStocks
Copy link
Contributor

pls fix the ci failure

@Lvnszn Lvnszn force-pushed the fix/route_with_more_invokers branch 5 times, most recently from 41daafa to b6cd6c2 Compare July 31, 2022 10:19
@Lvnszn Lvnszn force-pushed the fix/route_with_more_invokers branch 5 times, most recently from 5f4556d to fd2ebde Compare August 1, 2022 03:20
@zhaoyunxing92 zhaoyunxing92 added the bug Something isn't working label Aug 1, 2022
@zhaoyunxing92 zhaoyunxing92 self-requested a review August 1, 2022 03:36
@Lvnszn Lvnszn force-pushed the fix/route_with_more_invokers branch from fd2ebde to d0b807b Compare August 1, 2022 06:10
@Lvnszn Lvnszn force-pushed the fix/route_with_more_invokers branch from d0b807b to d1c5340 Compare August 1, 2022 06:17
@codecov-commenter
Copy link

Codecov Report

Merging #2000 (d1c5340) into 3.0 (013f0b2) will decrease coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              3.0    #2000      +/-   ##
==========================================
- Coverage   44.38%   44.37%   -0.02%     
==========================================
  Files         283      283              
  Lines       17067    17069       +2     
==========================================
- Hits         7575     7574       -1     
- Misses       8690     8693       +3     
  Partials      802      802              
Impacted Files Coverage Δ
cluster/cluster/zoneaware/cluster_interceptor.go 40.00% <ø> (ø)
cluster/router/tag/router.go 59.64% <ø> (ø)
common/url.go 59.04% <0.00%> (-0.27%) ⬇️
cluster/cluster/available/cluster_invoker.go 66.66% <0.00%> (-6.67%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us.

@AlexStocks AlexStocks merged commit 9334da0 into apache:3.0 Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants