-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix(#1974):fix shutdown InternalSignal default value #2003
Conversation
@@ -157,7 +157,7 @@ func (scb *ShutdownConfigBuilder) SetRejectRequest(rejectRequest bool) *Shutdown | |||
} | |||
|
|||
func (scb *ShutdownConfigBuilder) SetInternalSignal(internalSignal bool) *ShutdownConfigBuilder { | |||
scb.shutdownConfig.InternalSignal = internalSignal | |||
scb.shutdownConfig.InternalSignal = &internalSignal |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
不需要加锁保护下吗?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
应该不需要,没有并发的场景
pls fix the file confliction |
Codecov Report
@@ Coverage Diff @@
## 3.0 #2003 +/- ##
==========================================
+ Coverage 44.38% 44.59% +0.21%
==========================================
Files 283 283
Lines 17067 17073 +6
==========================================
+ Hits 7575 7614 +39
+ Misses 8690 8653 -37
- Partials 802 806 +4
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
typo: shotdown -> shutdown |
What this PR does:
#1974 fix shotdown InternalSignal default value
Which issue(s) this PR fixes:
Fixes #
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed