Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(#1974):fix shutdown InternalSignal default value #2003

Merged
merged 2 commits into from
Aug 10, 2022
Merged

Fix(#1974):fix shutdown InternalSignal default value #2003

merged 2 commits into from
Aug 10, 2022

Conversation

zhaoyunxing92
Copy link
Contributor

What this PR does:

#1974 fix shotdown InternalSignal default value

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@zhaoyunxing92 zhaoyunxing92 added the bug Something isn't working label Jul 30, 2022
@zhaoyunxing92 zhaoyunxing92 changed the title Fix(shotdown):fix shotdown InternalSignal default value Fix(#1974):fix shotdown InternalSignal default value Jul 30, 2022
@@ -157,7 +157,7 @@ func (scb *ShutdownConfigBuilder) SetRejectRequest(rejectRequest bool) *Shutdown
}

func (scb *ShutdownConfigBuilder) SetInternalSignal(internalSignal bool) *ShutdownConfigBuilder {
scb.shutdownConfig.InternalSignal = internalSignal
scb.shutdownConfig.InternalSignal = &internalSignal
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

不需要加锁保护下吗?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

应该不需要,没有并发的场景

@AlexStocks
Copy link
Contributor

pls fix the file confliction

@codecov-commenter
Copy link

Codecov Report

Merging #2003 (aab693f) into 3.0 (013f0b2) will increase coverage by 0.21%.
The diff coverage is 57.14%.

@@            Coverage Diff             @@
##              3.0    #2003      +/-   ##
==========================================
+ Coverage   44.38%   44.59%   +0.21%     
==========================================
  Files         283      283              
  Lines       17067    17073       +6     
==========================================
+ Hits         7575     7614      +39     
+ Misses       8690     8653      -37     
- Partials      802      806       +4     
Impacted Files Coverage Δ
config/graceful_shutdown.go 3.88% <0.00%> (ø)
config/graceful_shutdown_config.go 89.83% <66.66%> (-2.90%) ⬇️
cluster/cluster/available/cluster_invoker.go 66.66% <0.00%> (-6.67%) ⬇️
common/url.go 59.04% <0.00%> (-0.27%) ⬇️
cluster/router/tag/router.go 59.64% <0.00%> (ø)
cluster/cluster/zoneaware/cluster_interceptor.go 40.00% <0.00%> (ø)
cluster/cluster/base/cluster_invoker.go 37.77% <0.00%> (+13.33%) ⬆️
registry/zookeeper/service_discovery.go 17.07% <0.00%> (+15.85%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@justxuewei
Copy link
Member

typo: shotdown -> shutdown

@zhaoyunxing92 zhaoyunxing92 changed the title Fix(#1974):fix shotdown InternalSignal default value Fix(#1974):fix shutdown InternalSignal default value Aug 10, 2022
@zhaoyunxing92 zhaoyunxing92 merged commit bad8cf7 into apache:3.0 Aug 10, 2022
@zhaoyunxing92 zhaoyunxing92 deleted the default branch August 10, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants