Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: resolve placeholder #2014

Merged
merged 5 commits into from
Aug 19, 2022
Merged

Conversation

ZLBer
Copy link
Contributor

@ZLBer ZLBer commented Aug 11, 2022

What this PR does:
resolve placeholder ${xxx:defaultValue}
Which issue(s) this PR fixes:
Fixes #1983

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

Copy link
Contributor

@zhaoyunxing92 zhaoyunxing92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

很不错的PR,不过建议你可以看下这个代码:config#L33-L70 可以递归解析还可以设置默认值eg:${dubbo.provider.filter:nacos}

@codecov-commenter
Copy link

Codecov Report

Merging #2014 (fb92c94) into master (1d6b35f) will increase coverage by 0.27%.
The diff coverage is 93.10%.

@@            Coverage Diff             @@
##           master    #2014      +/-   ##
==========================================
+ Coverage   44.40%   44.67%   +0.27%     
==========================================
  Files         283      283              
  Lines       17067    17133      +66     
==========================================
+ Hits         7578     7654      +76     
+ Misses       8687     8672      -15     
- Partials      802      807       +5     
Impacted Files Coverage Δ
config/config_resolver.go 67.27% <93.10%> (+26.53%) ⬆️
cluster/cluster/available/cluster_invoker.go 66.66% <0.00%> (-6.67%) ⬇️
config/graceful_shutdown_config.go 89.83% <0.00%> (-2.90%) ⬇️
metrics/prometheus/reporter.go 30.25% <0.00%> (-1.54%) ⬇️
common/url.go 59.04% <0.00%> (-0.27%) ⬇️
cluster/router/tag/router.go 59.64% <0.00%> (ø)
cluster/cluster/zoneaware/cluster_interceptor.go 40.00% <0.00%> (ø)
metadata/definition/definition.go 70.66% <0.00%> (+7.87%) ⬆️
registry/zookeeper/service_discovery.go 17.07% <0.00%> (+15.85%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

配置模块支持递归查找
5 participants