Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the set of getty logger #2029

Merged
merged 2 commits into from
Aug 27, 2022
Merged

Add the set of getty logger #2029

merged 2 commits into from
Aug 27, 2022

Conversation

Leospard
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:
Fixes #

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • After import formatted, (using imports-formatter to run 'imports-formatter .' in project root, to format your import blocks, mentioned in CONTRIBUTING.md above)
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Aug 24, 2022

Codecov Report

Merging #2029 (bcbfe86) into 3.0 (19ddecf) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##              3.0    #2029      +/-   ##
==========================================
+ Coverage   44.60%   44.62%   +0.02%     
==========================================
  Files         283      283              
  Lines       17105    17106       +1     
==========================================
+ Hits         7630     7634       +4     
+ Misses       8669     8667       -2     
+ Partials      806      805       -1     
Impacted Files Coverage Δ
config/logger_config.go 63.33% <100.00%> (+0.62%) ⬆️
...tocol/rest/server/server_impl/go_restful_server.go 41.37% <0.00%> (-3.45%) ⬇️
metrics/prometheus/reporter.go 31.79% <0.00%> (+1.53%) ⬆️
cluster/loadbalance/ringhash/ring.go 87.32% <0.00%> (+2.81%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlexStocks
Copy link
Contributor

pls update the gost version in dubbo-getty.

@AlexStocks
Copy link
Contributor

pls change the getty version refer as apache/dubbo-getty#97

@cjphaha
Copy link
Member

cjphaha commented Aug 26, 2022

LGTM

@AlexStocks AlexStocks merged commit 486330d into apache:3.0 Aug 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants