Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue:204, branch develop #206

Merged
merged 1 commit into from
Sep 17, 2019
Merged

Conversation

joeyzhouy
Copy link
Contributor

fix issue:#204, branch develop

@AlexStocks
Copy link
Contributor

LGTM

@codecov-io
Copy link

Codecov Report

Merging #206 into develop will increase coverage by 1.06%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #206      +/-   ##
===========================================
+ Coverage    66.76%   67.82%   +1.06%     
===========================================
  Files           94       94              
  Lines         5847     5847              
===========================================
+ Hits          3904     3966      +62     
+ Misses        1544     1478      -66     
- Partials       399      403       +4
Impacted Files Coverage Δ
protocol/dubbo/client.go 70.94% <0%> (ø) ⬆️
protocol/dubbo/server.go 66.25% <0%> (ø) ⬆️
protocol/jsonrpc/server.go 59.79% <0%> (-1.51%) ⬇️
registry/etcdv3/registry.go 56.25% <0%> (-1.14%) ⬇️
protocol/dubbo/readwriter.go 70.37% <0%> (+2.46%) ⬆️
protocol/dubbo/codec.go 82.35% <0%> (+5.88%) ⬆️
protocol/dubbo/listener.go 64.02% <0%> (+14.02%) ⬆️
protocol/dubbo/pool.go 73.6% <0%> (+15.73%) ⬆️
cluster/cluster_impl/base_cluster_invoker.go 71.69% <0%> (+16.98%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92b2055...e35d29c. Read the comment docs.

@fangyincheng fangyincheng merged commit ff6fdf7 into apache:develop Sep 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants