-
Notifications
You must be signed in to change notification settings - Fork 929
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: nacosRegistry and polarisRegistry support register ip and port from env #2061
feat: nacosRegistry and polarisRegistry support register ip and port from env #2061
Conversation
f2f6173
to
47159bc
Compare
47159bc
to
bb48e50
Compare
Codecov Report
@@ Coverage Diff @@
## 3.0 #2061 +/- ##
==========================================
- Coverage 44.75% 44.61% -0.14%
==========================================
Files 283 281 -2
Lines 17108 16831 -277
==========================================
- Hits 7656 7509 -147
+ Misses 8643 8535 -108
+ Partials 809 787 -22
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, thanks for your contributions.
bb48e50
to
c431628
Compare
What this PR does:
Which issue(s) this PR fixes:
Fixes #2060
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed