Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: nacosRegistry and polarisRegistry support register ip and port from env #2061

Merged
merged 1 commit into from
Sep 26, 2022

Conversation

jiangy
Copy link
Contributor

@jiangy jiangy commented Sep 25, 2022

What this PR does:

Which issue(s) this PR fixes:
Fixes #2060

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@jiangy jiangy force-pushed the zq/support-register-env-ip-and-port branch from f2f6173 to 47159bc Compare September 25, 2022 13:10
common/host_util.go Outdated Show resolved Hide resolved
common/host_util.go Outdated Show resolved Hide resolved
@jiangy jiangy force-pushed the zq/support-register-env-ip-and-port branch from 47159bc to bb48e50 Compare September 26, 2022 12:02
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2022

Codecov Report

Merging #2061 (47159bc) into 3.0 (1c3be33) will decrease coverage by 0.13%.
The diff coverage is 68.75%.

❗ Current head 47159bc differs from pull request most recent head c431628. Consider uploading reports for the commit c431628 to get more accurate results

@@            Coverage Diff             @@
##              3.0    #2061      +/-   ##
==========================================
- Coverage   44.75%   44.61%   -0.14%     
==========================================
  Files         283      281       -2     
  Lines       17108    16831     -277     
==========================================
- Hits         7656     7509     -147     
+ Misses       8643     8535     -108     
+ Partials      809      787      -22     
Impacted Files Coverage Δ
metadata/definition/definition.go 70.66% <ø> (ø)
metadata/identifier/base_metadata_identifier.go 86.48% <0.00%> (-7.64%) ⬇️
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-8.61%) ⬇️
xds/client/bootstrap/bootstrap.go 59.11% <0.00%> (ø)
xds/utils/credentials/xds/handshake_info.go 41.46% <ø> (ø)
common/host_util.go 100.00% <100.00%> (+40.00%) ⬆️
registry/nacos/registry.go 46.00% <100.00%> (+2.68%) ⬆️
cluster/cluster/base/cluster_invoker.go 24.44% <0.00%> (-13.34%) ⬇️
cluster/loadbalance/ringhash/ring.go 84.50% <0.00%> (-2.82%) ⬇️
... and 6 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for your contributions.

@jiangy jiangy force-pushed the zq/support-register-env-ip-and-port branch from bb48e50 to c431628 Compare September 26, 2022 12:18
@AlexStocks AlexStocks merged commit ac587eb into apache:3.0 Sep 26, 2022
@jiangy jiangy deleted the zq/support-register-env-ip-and-port branch September 27, 2022 02:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants