Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: leastactive choose wrong invoker #2068

Merged
merged 1 commit into from
Oct 6, 2022

Conversation

cjphaha
Copy link
Member

@cjphaha cjphaha commented Oct 4, 2022

If only one invoker has the smallest active number, the 0 th value of leastIndexes should be taken as the number of the invoker, rather than the 0 th value of the invoker,because the number 0 of the invoker is not the invoker with the lowest activity

@cjphaha cjphaha changed the base branch from master to 3.0 October 4, 2022 21:04
@codecov-commenter
Copy link

Codecov Report

Merging #2068 (b971876) into 3.0 (705319d) will decrease coverage by 0.07%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              3.0    #2068      +/-   ##
==========================================
- Coverage   44.68%   44.61%   -0.08%     
==========================================
  Files         281      281              
  Lines       16836    16836              
==========================================
- Hits         7524     7511      -13     
- Misses       8523     8538      +15     
+ Partials      789      787       -2     
Impacted Files Coverage Δ
cluster/loadbalance/leastactive/loadbalance.go 91.66% <0.00%> (ø)
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-8.61%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@AlexStocks AlexStocks merged commit 9f1a9f2 into apache:3.0 Oct 6, 2022
@justxuewei justxuewei added this to the v3.0.4 milestone Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants