Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tls support: dubbo/dubbo3/grpc protocol #2073

Merged
merged 2 commits into from
Nov 8, 2022
Merged

Conversation

ZLBer
Copy link
Contributor

@ZLBer ZLBer commented Oct 7, 2022

What this PR does:

dubbo-go tls support:

test samples for above: after this pr merge, will commit in dubboo-go-samples

  • dubbo protocol
  • dubbo3 protocol
  • grpc protocol
  • using xds creds

next:

  • mTLS support

Which issue(s) this PR fixes:
Fixes #2054

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

protocol/grpc/client.go Outdated Show resolved Hide resolved
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2022

Codecov Report

Merging #2073 (43fbccf) into 3.0 (19668c0) will decrease coverage by 0.23%.
The diff coverage is 8.86%.

@@            Coverage Diff             @@
##              3.0    #2073      +/-   ##
==========================================
- Coverage   44.68%   44.45%   -0.24%     
==========================================
  Files         281      282       +1     
  Lines       16836    16913      +77     
==========================================
- Hits         7524     7518       -6     
- Misses       8522     8606      +84     
+ Partials      790      789       -1     
Impacted Files Coverage Δ
config/protocol_config.go 50.00% <ø> (ø)
config/reference_config.go 31.03% <0.00%> (-0.95%) ⬇️
config/service_config.go 52.09% <0.00%> (-0.96%) ⬇️
config/tls_config.go 0.00% <0.00%> (ø)
protocol/grpc/client.go 63.38% <16.66%> (-9.96%) ⬇️
protocol/grpc/server.go 68.23% <31.25%> (-8.91%) ⬇️
metadata/report/delegate/delegate_report.go 26.49% <0.00%> (-8.61%) ⬇️
cluster/loadbalance/ringhash/ring.go 87.32% <0.00%> (+2.81%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

config/tls_config.go Outdated Show resolved Hide resolved
@ZLBer ZLBer requested review from AlexStocks and binbin0325 and removed request for AlexStocks and binbin0325 October 22, 2022 18:22
@AlexStocks AlexStocks merged commit 9ca9bae into apache:3.0 Nov 8, 2022
@justxuewei justxuewei added this to the v3.0.4 milestone Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants