add polaris subscribe #2100
Merged
add polaris subscribe #2100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 3.0 #2100 +/- ##
==========================================
- Coverage 44.74% 44.53% -0.21%
==========================================
Files 281 282 +1
Lines 16864 16941 +77
==========================================
- Hits 7546 7545 -1
- Misses 8527 8606 +79
+ Partials 791 790 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
chuntaojun
suggested changes
Nov 5, 2022
| @@ -67,11 +68,13 @@ func newPolarisRegistry(url *common.URL) (registry.Registry, error) { | |||
| } | |||
|
|
|||
| type polarisRegistry struct { | |||
| consumer api.ConsumerAPI | |||
| namespace string | |||
registry/polaris/registry.go
Outdated
| }) | ||
| } | ||
| registry.NewServiceInstancesChangedEvent(serviceName, dubboInstances) | ||
| listener.Next() |
There was a problem hiding this comment.
你这里不吧事件传递给 listener 吗？你的把事件塞到 chan 里面去呀，不然你下面的 listener.Next 等啥呢？
There was a problem hiding this comment.
这个事件需要传递给listener吗，这个是一个notify事件，执行通知就行了
There was a problem hiding this comment.
你先看下 nacos.subscribe 里面做的事情
There was a problem hiding this comment.
你先看下 nacos.subscribe 里面做的事情，再看看你这里，你都没有吧 event 传到 listener 里面 chan，你这里 next 不就是死等吗
chuntaojun
reviewed
Nov 9, 2022
registry/polaris/listener.go
Outdated
|
|
||
| // Next returns next service event once received | ||
| func (pl *polarisListener) Next() (*registry.ServiceEvent, error) { | ||
| for { | ||
| select { | ||
| case <-pl.closeCh: | ||
| logger.Warnf("polaris listener is close!listenUrl:%+v", pl.listenUrl) | ||
| logger.Warnf("polaris listener is close!listenUrl:%+v") |
remoting/polaris/polaris.yaml
Outdated
| @@ -93,3 +82,5 @@ consumer: | |||
| plugin: | |||
| subscribeLocalChannel: | |||
| channelBufferSize: 50 | |||
| statReporter: | |||
There was a problem hiding this comment.
放错位置了，就在原来的基础上改，不要调整 statReporter 的位置
|
都改了 |
chuntaojun
approved these changes
Nov 9, 2022
zhaoyunxing92
approved these changes
Nov 10, 2022
AlexStocks
approved these changes
Nov 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Which issue(s) this PR fixes:
Fixes #
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed