feat: tls support for protocol dubbo/dubbo3 #2117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZLBer
force-pushed
the
add_tls_support
branch
from
8775dec
to
9014240
Compare
# Conflicts: # go.mod # go.sum
ZLBer
force-pushed
the
add_tls_support
branch
from
39aa210
to
ddec760
Compare
Codecov Report
@@ Coverage Diff @@
## 3.0 #2117 +/- ##
=======================================
Coverage 45.21% 45.21%
=======================================
Files 283 283
Lines 17572 17572
=======================================
Hits 7946 7946
Misses 8795 8795
Partials 831 831 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
ZLBer
force-pushed
the
add_tls_support
branch
3 times, most recently
from
bd1570b
to
34416ff
Compare
|
@AlexStocks @binbin0325 @zhaoyunxing92 pls review this pr |
ZLBer
force-pushed
the
add_tls_support
branch
from
34416ff
to
05e807e
Compare
# Conflicts: # go.mod
AlexStocks
approved these changes
Nov 26, 2022
binbin0325
approved these changes
Nov 26, 2022
justxuewei
reviewed
Nov 27, 2022
justxuewei
approved these changes
Nov 27, 2022
zhaoyunxing92
approved these changes
Nov 27, 2022
|
Kudos, SonarCloud Quality Gate passed!
|
5 tasks
binbin0325
pushed a commit
to binbin0325/dubbo-go
that referenced
this pull request
Dec 10, 2022
* tls support for grpc protocol * tls support for grpc protocol * feat: tls support for protocol dubbo/dubbo3 * feat: tls support for protocol dubbo/dubbo3 * feat: add log for tls * feat: move tlsConfig to rootConfig * feat: move tlsConfig to rootConfig
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
dubbo-go tls support：
TODO: test samples for above: after this pr merge, will commit in dubboo-go-samples
Which issue(s) this PR fixes:
Fixes #2054
You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed