Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ISSUE #2122] refactor registry polaris project #2125

Merged
merged 4 commits into from
Nov 16, 2022

Conversation

chuntaojun
Copy link
Contributor

What this PR does:

Which issue(s) this PR fixes:
Fixes #2122

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@chuntaojun chuntaojun changed the title refactor registry polaris project [ISSUE #2122] refactor registry polaris project Nov 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #2125 (09c98a1) into 3.0 (ef53b9b) will decrease coverage by 0.39%.
The diff coverage is 13.29%.

❗ Current head 09c98a1 differs from pull request most recent head 9f55684. Consider uploading reports for the commit 9f55684 to get more accurate results

@@            Coverage Diff             @@
##              3.0    #2125      +/-   ##
==========================================
- Coverage   44.70%   44.31%   -0.40%     
==========================================
  Files         281      282       +1     
  Lines       16864    16982     +118     
==========================================
- Hits         7539     7525      -14     
- Misses       8537     8668     +131     
- Partials      788      789       +1     
Impacted Files Coverage Δ
common/host_util.go 100.00% <ø> (ø)
config/protocol_config.go 50.00% <ø> (ø)
config/reference_config.go 25.71% <0.00%> (-6.27%) ⬇️
config/service_config.go 52.09% <0.00%> (-0.96%) ⬇️
config/tls_config.go 0.00% <0.00%> (ø)
config_center/nacos/impl.go 40.59% <ø> (ø)
config_center/nacos/listener.go 0.00% <ø> (ø)
metadata/report/nacos/report.go 43.57% <ø> (ø)
registry/nacos/listener.go 0.00% <0.00%> (ø)
registry/nacos/registry.go 46.00% <ø> (ø)
... and 8 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Nov 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

registry/polaris/core.go Show resolved Hide resolved
@AlexStocks AlexStocks merged commit d70b6c0 into apache:3.0 Nov 16, 2022
@justxuewei justxuewei added this to the v3.0.4 milestone Dec 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants