Fix: service discovery registry notify before return #2168

Leospard · 2022-12-23T12:56:28Z

在异步订阅前先同步获取provider实例。(当前 pr 修复 serviceDiscoveryRegistry )

What this PR does:

Which issue(s) this PR fixes:
Fixes #1991

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

All ut passed (run 'go test ./...' in project root)
After go-fmt ed , run 'go fmt project' using goland.
Golangci-lint passed, run 'sudo golangci-lint run' in project root.
Your new-created file needs to have apache license at the top, like other existed file does.
All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

codecov-commenter · 2022-12-23T13:12:09Z

Codecov Report

Merging #2168 (b0a3801) into 3.0 (2567655) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##              3.0    #2168      +/-   ##
==========================================
+ Coverage   44.26%   44.27%   +0.01%     
==========================================
  Files         283      283              
  Lines       17108    17128      +20     
==========================================
+ Hits         7572     7584      +12     
- Misses       8741     8748       +7     
- Partials      795      796       +1

Impacted Files	Coverage Δ
...y/event/service_instances_changed_listener_impl.go	`0.00% <0.00%> (ø)`
...try/servicediscovery/service_discovery_registry.go	`1.11% <0.00%> (-0.14%)`	⬇️
metrics/prometheus/reporter.go	`30.25% <0.00%> (-1.54%)`	⬇️
metadata/service/local/service_proxy.go	`62.35% <0.00%> (-0.75%)`	⬇️
cluster/loadbalance/ringhash/ring.go	`87.32% <0.00%> (+2.81%)`	⬆️
metadata/report/delegate/delegate_report.go	`35.09% <0.00%> (+8.60%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

AlexStocks · 2023-01-03T13:02:09Z

@Leospard 改完了吗？改完的话，去掉 WIP

Leospard · 2023-01-04T02:20:17Z

@Leospard 改完了吗？改完的话，去掉 WIP

还有一些要做的，这周完善一下👌

AlexStocks · 2023-01-05T06:04:27Z

registry/servicediscovery/service_discovery_registry.go

+			logger.Warnf("Instance metadata is nil: %s", instance.GetHost())
+			continue
+		}
+		revision := instance.GetMetadata()[constant.ExportedServicesRevisionPropertyName]


这里不加个 ok 判断吗？这么铁定能拿到值？

只要服务端是应用级服务发现，则在导入 dubbo.apache.org/dubbo-go/v3/registry/event 包时一定会初始化这个 constant.ExportedServicesRevisionPropertyName 字段的值，最后将相应字段写入注册中心。如果服务端不是应用级服务发现，在 GetInstance 时应该就会报错，走不到这步拿 revision 了。不过确实也可以加一下【我主要参考正常应用级服务发现的代码，没做 ok 的判断，我也就直接拿过来用了】

加上 ok 判断吧。

sonarcloud · 2023-01-05T09:32:08Z

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
0 Code Smells

No Coverage information
0.0% Duplication

* Fix: service discovery registry notify before return * format import * modify notify url * add judge about the existence of instance's metadata revision

* 解决 consumer 不断重连已下线的 provider meta service 问题 (#2166) * registry type support all * fix test * set default to interface * use default protocol registry * fix unit test * use swith to judge * add registry support all test * Resolve registry name conflicts * fix ut err * fix #2159 * del front * del front Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local> Co-authored-by: bob <bob@bobdeMacBook-Pro.local> Co-authored-by: bobtthp <bobtthp@bob1.local> Co-authored-by: bob <bob@bob.local> * build(deps): bump github.com/hashicorp/vault/sdk from 0.6.0 to 0.6.2 (#2169) Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.6.0 to 0.6.2. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v0.6.0...v0.6.2) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault/sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix: service discovery registry notify before return (#2168) * Fix: service discovery registry notify before return * format import * modify notify url * add judge about the existence of instance's metadata revision * build(deps): bump github.com/knadh/koanf from 1.4.4 to 1.4.5 (#2179) Bumps [github.com/knadh/koanf](https://github.com/knadh/koanf) from 1.4.4 to 1.4.5. - [Release notes](https://github.com/knadh/koanf/releases) - [Commits](knadh/koanf@v1.4.4...v1.4.5) --- updated-dependencies: - dependency-name: github.com/knadh/koanf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix: Replace assignment behavior with copy operation to avoid OOM problem (#2182) * build(deps): bump github.com/hashicorp/vault/sdk from 0.6.2 to 0.7.0 (#2185) Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.6.2 to 0.7.0. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v0.6.2...v0.7.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault/sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/nacos-group/nacos-sdk-go (#2183) Bumps [github.com/nacos-group/nacos-sdk-go](https://github.com/nacos-group/nacos-sdk-go) from 1.1.3 to 1.1.4. - [Release notes](https://github.com/nacos-group/nacos-sdk-go/releases) - [Commits](nacos-group/nacos-sdk-go@v1.1.3...v1.1.4) --- updated-dependencies: - dependency-name: github.com/nacos-group/nacos-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/knadh/koanf from 1.4.5 to 1.5.0 (#2187) Bumps [github.com/knadh/koanf](https://github.com/knadh/koanf) from 1.4.5 to 1.5.0. - [Release notes](https://github.com/knadh/koanf/releases) - [Commits](knadh/koanf@v1.4.5...v1.5.0) --- updated-dependencies: - dependency-name: github.com/knadh/koanf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump go.etcd.io/etcd/client/v3 from 3.5.6 to 3.5.7 (#2190) Bumps [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) from 3.5.6 to 3.5.7. - [Release notes](https://github.com/etcd-io/etcd/releases) - [Changelog](https://github.com/etcd-io/etcd/blob/main/Dockerfile-release.amd64) - [Commits](etcd-io/etcd@v3.5.6...v3.5.7) --- updated-dependencies: - dependency-name: go.etcd.io/etcd/client/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/RoaringBitmap/roaring from 1.2.0 to 1.2.2 (#2188) Bumps [github.com/RoaringBitmap/roaring](https://github.com/RoaringBitmap/roaring) from 1.2.0 to 1.2.2. - [Release notes](https://github.com/RoaringBitmap/roaring/releases) - [Commits](RoaringBitmap/roaring@v1.2.0...v1.2.2) --- updated-dependencies: - dependency-name: github.com/RoaringBitmap/roaring dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/RoaringBitmap/roaring from 1.2.2 to 1.2.3 (#2195) Bumps [github.com/RoaringBitmap/roaring](https://github.com/RoaringBitmap/roaring) from 1.2.2 to 1.2.3. - [Release notes](https://github.com/RoaringBitmap/roaring/releases) - [Commits](RoaringBitmap/roaring@v1.2.2...v1.2.3) --- updated-dependencies: - dependency-name: github.com/RoaringBitmap/roaring dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [ISSUE #2172] Fix/polaris governance (#2171) * 解决 consumer 不断重连已下线的 provider meta service 问题 (#2166) * registry type support all * fix test * set default to interface * use default protocol registry * fix unit test * use swith to judge * add registry support all test * Resolve registry name conflicts * fix ut err * fix #2159 * del front * del front Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local> Co-authored-by: bob <bob@bobdeMacBook-Pro.local> Co-authored-by: bobtthp <bobtthp@bob1.local> Co-authored-by: bob <bob@bob.local> * build(deps): bump github.com/hashicorp/vault/sdk from 0.6.0 to 0.6.2 (#2169) Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.6.0 to 0.6.2. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v0.6.0...v0.6.2) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault/sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor:polaris ability open judge * refactor:polaris ability open judge Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: bobtthp <gzqtianc@gmail.com> Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local> Co-authored-by: bob <bob@bobdeMacBook-Pro.local> Co-authored-by: bobtthp <bobtthp@bob1.local> Co-authored-by: bob <bob@bob.local> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Dynamic update config for logger level & metric enable (#2180) * dynamically update logger level & metric enable * prometheus server start & shutdown * check nil * fix ci Co-authored-by: huangwenkang <642380437@qq> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: bobtthp <gzqtianc@gmail.com> Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local> Co-authored-by: bob <bob@bobdeMacBook-Pro.local> Co-authored-by: bobtthp <bobtthp@bob1.local> Co-authored-by: bob <bob@bob.local> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Leo Shen <694963063@qq.com> Co-authored-by: Jason Peng <lvs.pjx@gmail.com> Co-authored-by: liaochuntao <liaochuntao@live.com> Co-authored-by: Wenkang Huang <52915386+huangwenkan9@users.noreply.github.com> Co-authored-by: huangwenkang <642380437@qq>

* [ISSUE #2123] Feat/polaris ratelimit (#2127) * feat:support polaris limit ability * [ISSUE #2172] Fix/polaris governance (#2171) * 解决 consumer 不断重连已下线的 provider meta service 问题 (#2166) * registry type support all * fix test * set default to interface * use default protocol registry * fix unit test * use swith to judge * add registry support all test * Resolve registry name conflicts * fix ut err * fix #2159 * del front * del front Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local> Co-authored-by: bob <bob@bobdeMacBook-Pro.local> Co-authored-by: bobtthp <bobtthp@bob1.local> Co-authored-by: bob <bob@bob.local> * build(deps): bump github.com/hashicorp/vault/sdk from 0.6.0 to 0.6.2 (#2169) Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.6.0 to 0.6.2. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v0.6.0...v0.6.2) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault/sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor:polaris ability open judge * refactor:polaris ability open judge Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: bobtthp <gzqtianc@gmail.com> Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local> Co-authored-by: bob <bob@bobdeMacBook-Pro.local> Co-authored-by: bobtthp <bobtthp@bob1.local> Co-authored-by: bob <bob@bob.local> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Dynamic update config for logger level & metric enable (#2180) * dynamically update logger level & metric enable * prometheus server start & shutdown * check nil * fix ci Co-authored-by: huangwenkang <642380437@qq> * Revert "Dynamic update config for logger level & metric enable (#2180)" (#2199) This reverts commit 4c6a99b. * Revert "[ISSUE #2172] Fix/polaris governance (#2171)" (#2200) This reverts commit c1a0698. * sync: Merge the 3.0 branch into the master branch (#2201) * 解决 consumer 不断重连已下线的 provider meta service 问题 (#2166) * registry type support all * fix test * set default to interface * use default protocol registry * fix unit test * use swith to judge * add registry support all test * Resolve registry name conflicts * fix ut err * fix #2159 * del front * del front Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local> Co-authored-by: bob <bob@bobdeMacBook-Pro.local> Co-authored-by: bobtthp <bobtthp@bob1.local> Co-authored-by: bob <bob@bob.local> * build(deps): bump github.com/hashicorp/vault/sdk from 0.6.0 to 0.6.2 (#2169) Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.6.0 to 0.6.2. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v0.6.0...v0.6.2) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault/sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix: service discovery registry notify before return (#2168) * Fix: service discovery registry notify before return * format import * modify notify url * add judge about the existence of instance's metadata revision * build(deps): bump github.com/knadh/koanf from 1.4.4 to 1.4.5 (#2179) Bumps [github.com/knadh/koanf](https://github.com/knadh/koanf) from 1.4.4 to 1.4.5. - [Release notes](https://github.com/knadh/koanf/releases) - [Commits](knadh/koanf@v1.4.4...v1.4.5) --- updated-dependencies: - dependency-name: github.com/knadh/koanf dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Fix: Replace assignment behavior with copy operation to avoid OOM problem (#2182) * build(deps): bump github.com/hashicorp/vault/sdk from 0.6.2 to 0.7.0 (#2185) Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.6.2 to 0.7.0. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v0.6.2...v0.7.0) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault/sdk dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/nacos-group/nacos-sdk-go (#2183) Bumps [github.com/nacos-group/nacos-sdk-go](https://github.com/nacos-group/nacos-sdk-go) from 1.1.3 to 1.1.4. - [Release notes](https://github.com/nacos-group/nacos-sdk-go/releases) - [Commits](nacos-group/nacos-sdk-go@v1.1.3...v1.1.4) --- updated-dependencies: - dependency-name: github.com/nacos-group/nacos-sdk-go dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/knadh/koanf from 1.4.5 to 1.5.0 (#2187) Bumps [github.com/knadh/koanf](https://github.com/knadh/koanf) from 1.4.5 to 1.5.0. - [Release notes](https://github.com/knadh/koanf/releases) - [Commits](knadh/koanf@v1.4.5...v1.5.0) --- updated-dependencies: - dependency-name: github.com/knadh/koanf dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump go.etcd.io/etcd/client/v3 from 3.5.6 to 3.5.7 (#2190) Bumps [go.etcd.io/etcd/client/v3](https://github.com/etcd-io/etcd) from 3.5.6 to 3.5.7. - [Release notes](https://github.com/etcd-io/etcd/releases) - [Changelog](https://github.com/etcd-io/etcd/blob/main/Dockerfile-release.amd64) - [Commits](etcd-io/etcd@v3.5.6...v3.5.7) --- updated-dependencies: - dependency-name: go.etcd.io/etcd/client/v3 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/RoaringBitmap/roaring from 1.2.0 to 1.2.2 (#2188) Bumps [github.com/RoaringBitmap/roaring](https://github.com/RoaringBitmap/roaring) from 1.2.0 to 1.2.2. - [Release notes](https://github.com/RoaringBitmap/roaring/releases) - [Commits](RoaringBitmap/roaring@v1.2.0...v1.2.2) --- updated-dependencies: - dependency-name: github.com/RoaringBitmap/roaring dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * build(deps): bump github.com/RoaringBitmap/roaring from 1.2.2 to 1.2.3 (#2195) Bumps [github.com/RoaringBitmap/roaring](https://github.com/RoaringBitmap/roaring) from 1.2.2 to 1.2.3. - [Release notes](https://github.com/RoaringBitmap/roaring/releases) - [Commits](RoaringBitmap/roaring@v1.2.2...v1.2.3) --- updated-dependencies: - dependency-name: github.com/RoaringBitmap/roaring dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * [ISSUE #2172] Fix/polaris governance (#2171) * 解决 consumer 不断重连已下线的 provider meta service 问题 (#2166) * registry type support all * fix test * set default to interface * use default protocol registry * fix unit test * use swith to judge * add registry support all test * Resolve registry name conflicts * fix ut err * fix #2159 * del front * del front Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local> Co-authored-by: bob <bob@bobdeMacBook-Pro.local> Co-authored-by: bobtthp <bobtthp@bob1.local> Co-authored-by: bob <bob@bob.local> * build(deps): bump github.com/hashicorp/vault/sdk from 0.6.0 to 0.6.2 (#2169) Bumps [github.com/hashicorp/vault/sdk](https://github.com/hashicorp/vault) from 0.6.0 to 0.6.2. - [Release notes](https://github.com/hashicorp/vault/releases) - [Changelog](https://github.com/hashicorp/vault/blob/main/CHANGELOG.md) - [Commits](hashicorp/vault@v0.6.0...v0.6.2) --- updated-dependencies: - dependency-name: github.com/hashicorp/vault/sdk dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * refactor:polaris ability open judge * refactor:polaris ability open judge Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: bobtthp <gzqtianc@gmail.com> Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local> Co-authored-by: bob <bob@bobdeMacBook-Pro.local> Co-authored-by: bobtthp <bobtthp@bob1.local> Co-authored-by: bob <bob@bob.local> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Dynamic update config for logger level & metric enable (#2180) * dynamically update logger level & metric enable * prometheus server start & shutdown * check nil * fix ci Co-authored-by: huangwenkang <642380437@qq> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: bobtthp <gzqtianc@gmail.com> Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local> Co-authored-by: bob <bob@bobdeMacBook-Pro.local> Co-authored-by: bobtthp <bobtthp@bob1.local> Co-authored-by: bob <bob@bob.local> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Leo Shen <694963063@qq.com> Co-authored-by: Jason Peng <lvs.pjx@gmail.com> Co-authored-by: liaochuntao <liaochuntao@live.com> Co-authored-by: Wenkang Huang <52915386+huangwenkan9@users.noreply.github.com> Co-authored-by: huangwenkang <642380437@qq> * ci --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: liaochuntao <liaochuntao@live.com> Co-authored-by: AlexStocks <alexstocks@foxmail.com> Co-authored-by: bobtthp <gzqtianc@gmail.com> Co-authored-by: bobtthp <bobtthp@bob-Mac-mini.local> Co-authored-by: bob <bob@bobdeMacBook-Pro.local> Co-authored-by: bobtthp <bobtthp@bob1.local> Co-authored-by: bob <bob@bob.local> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Wenkang Huang <52915386+huangwenkan9@users.noreply.github.com> Co-authored-by: huangwenkang <642380437@qq> Co-authored-by: Xuewei Niu <justxuewei@apache.org> Co-authored-by: Leo Shen <694963063@qq.com> Co-authored-by: Jason Peng <lvs.pjx@gmail.com> Co-authored-by: aqi <aqi@xiaoshijie.com>

Leospard added 2 commits December 23, 2022 20:52

Fix: service discovery registry notify before return

64f3e44

format import

ee183f1

binbin0325 approved these changes Jan 3, 2023

View reviewed changes

modify notify url

ebec1c3

Leospard changed the title ~~【WIP】Fix: service discovery registry notify before return~~ Fix: service discovery registry notify before return Jan 5, 2023

AlexStocks reviewed Jan 5, 2023

View reviewed changes

add judge about the existence of instance's metadata revision

b0a3801

AlexStocks approved these changes Jan 5, 2023

View reviewed changes

zhaoyunxing92 approved these changes Jan 6, 2023

View reviewed changes

AlexStocks merged commit c2bb0b3 into apache:3.0 Jan 6, 2023

AlexStocks mentioned this pull request Jan 13, 2023

Generic call does not work with 3.0 service discovery model #2034

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix: service discovery registry notify before return #2168

Fix: service discovery registry notify before return #2168

Leospard commented Dec 23, 2022

codecov-commenter commented Dec 23, 2022 •

edited

Loading

AlexStocks commented Jan 3, 2023

Leospard commented Jan 4, 2023

AlexStocks Jan 5, 2023

Leospard Jan 5, 2023

AlexStocks Jan 5, 2023

Leospard Jan 5, 2023

sonarcloud bot commented Jan 5, 2023

Fix: service discovery registry notify before return #2168

Fix: service discovery registry notify before return #2168

Conversation

Leospard commented Dec 23, 2022

codecov-commenter commented Dec 23, 2022 • edited Loading

Codecov Report

AlexStocks commented Jan 3, 2023

Leospard commented Jan 4, 2023

AlexStocks Jan 5, 2023

Choose a reason for hiding this comment

Leospard Jan 5, 2023

Choose a reason for hiding this comment

AlexStocks Jan 5, 2023

Choose a reason for hiding this comment

Leospard Jan 5, 2023

Choose a reason for hiding this comment

sonarcloud bot commented Jan 5, 2023

codecov-commenter commented Dec 23, 2022 •

edited

Loading