Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade hessian2 to support java wrapper types #2222

Merged
merged 1 commit into from
Feb 26, 2023

Conversation

tiltwind
Copy link
Contributor

@tiltwind tiltwind commented Feb 21, 2023

What this PR does:
hessian2 is trying to support java wrapper types, apache/dubbo-go-hessian2#349.

Which issue(s) this PR fixes:
NONE

You should pay attention to items below to ensure your pr passes our ci test
We do not merge pr with ci tests failed

  • All ut passed (run 'go test ./...' in project root)
  • After go-fmt ed , run 'go fmt project' using goland.
  • Golangci-lint passed, run 'sudo golangci-lint run' in project root.
  • Your new-created file needs to have apache license at the top, like other existed file does.
  • All integration test passed. You can run integration test locally (with docker env). Clone our dubbo-go-samples project and replace the go.mod to your dubbo-go, and run 'sudo sh start_integration_test.sh' at root of samples project root. (M1 Slice is not Support)

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2023

Codecov Report

Merging #2222 (ac2df65) into 3.0 (91a0465) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head ac2df65 differs from pull request most recent head 8a500e9. Consider uploading reports for the commit 8a500e9 to get more accurate results

@@            Coverage Diff             @@
##              3.0    #2222      +/-   ##
==========================================
- Coverage   44.13%   44.12%   -0.02%     
==========================================
  Files         283      283              
  Lines       17172    17172              
==========================================
- Hits         7579     7577       -2     
- Misses       8798     8799       +1     
- Partials      795      796       +1     
Impacted Files Coverage Δ
cluster/cluster/failback/cluster_invoker.go 75.82% <0.00%> (-2.20%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@tiltwind tiltwind changed the title ci test for hessian2 major version 2.0 upgrade hessian2 to support java wrapper types Feb 26, 2023
@sonarcloud
Copy link

sonarcloud bot commented Feb 26, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
3.4% 3.4% Duplication

@AlexStocks AlexStocks merged commit 1034562 into apache:3.0 Feb 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants