Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: implement RemoveConfig API for nacos and zookeeper #2234

Merged
merged 1 commit into from
Mar 25, 2023
Merged

feat: implement RemoveConfig API for nacos and zookeeper #2234

merged 1 commit into from
Mar 25, 2023

Conversation

seriouszyx
Copy link
Member

What this PR does:

Implement RemoveConfig API for nacos and zookeeper.

Which issue(s) this PR fixes:

Fixes #2233

@AlexStocks
Copy link
Contributor

AlexStocks commented Feb 28, 2023 •
edited
Loading

@seriouszyx 把目标分支改为 3.0，或者先帮忙把 3.0 代码到 3.1 同步下，完成同步后再进行 这个 pr 的工作。

@seriouszyx seriouszyx changed the base branch from 3.1 to 3.0 March 1, 2023 01:33
@seriouszyx
feat: implement RemoveConfig API for nacos and zookeeper
003b74c 
Signed-off-by: Yixiang <seriouszyx@foxmail.com>
@sonarcloud
Copy link

sonarcloud bot commented Mar 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@seriouszyx
Copy link
Member Author

@seriouszyx 把目标分支改为 3.0，或者先帮忙把 3.0 代码到 3.1 同步下，完成同步后再进行 这个 pr 的工作。

目前不是很熟悉 dubbo-go 的代码，暂时将目标分支改为 3.0 😀

justxuewei
justxuewei approved these changes Mar 7, 2023
View reviewed changes
Copy link
Member

@justxuewei justxuewei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks!

@justxuewei
Copy link
Member

@zhaoyunxing92 PTAL

@chickenlj chickenlj self-requested a review March 25, 2023 03:21
@chickenlj chickenlj merged commit 6c26c99 into apache:3.0 Mar 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexStocks AlexStocks AlexStocks approved these changes

@justxuewei justxuewei justxuewei approved these changes

@zhaoyunxing92 zhaoyunxing92 Awaiting requested review from zhaoyunxing92

@chickenlj chickenlj Awaiting requested review from chickenlj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement RemoveConfig API for nacos and zookeeper
4 participants
@seriouszyx @AlexStocks @justxuewei @chickenlj